Bug#1010287: libnet-ssleay-perl: FTBFS: bad line in substvars file debian/libnet-ssleay-perl.substvars at line 2

[Niko Tyni]

Control: reassign -1 perl-openssl-defaults 5
Control: tag -1 sid bookworm
Control: retitle -1 perl-openssl-defaults: generated substvar should not end in a newline
Control: affects -1 src:libnet-ssleay-perl

On Wed, Apr 27, 2022 at 03:28:06PM -0700, Daniel Schepler wrote:
> Source: libnet-ssleay-perl
> Version: 1.92-1
> Severity: serious

> dpkg-shlibdeps: error: bad line in substvars file
> debian/libnet-ssleay-perl.substvars at line 2
> dh_shlibdeps: error: dpkg-shlibdeps
> -Tdebian/libnet-ssleay-perl.substvars
> debian/libnet-ssleay-perl/usr/lib/x86_64-linux-gnu/perl5/5.34/auto/Net/SSLeay/SSLeay.so
> returned exit code 255

> Looking at the file it's complaining about,
> debian/libnet-ssleay-perl.substvars contains:
> 
> perl:Depends=perl, perl-openssl-abi-1.1
> , perlapi-5.34.0
> 
> (My best guess would be that this is a bug in perl-openssl-defaults /
> dh_perl_openssl, but it's just a guess...)

Thanks.

Looks like Debian::Debhelper::Dh_Lib::addsubstvar no longer strips
newlines from substvar values. I think it regressed with debhelper 13.7,
probably

  https://salsa.debian.org/debian/debhelper/-/commit/99892be481c1dd06d9866854a2c14e6a70ae12b7

That said, I think this should be fixed in perl-openssl-defaults by not
putting the newline there in the first place.

Copying Niels; you might want to restore the newline handling if there
are other affected addsubstvar users. If not, I wonder if debhelper
should Break perl-openssl-defaults (<= 5) once we have fixed this.
-- 
Niko Tyni   ntyni at debian.org