Bug#1045546: rename: Fails to build source after successful build

[Lucas Nussbaum]

Source: rename
Version: 2.01-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package rename
> dpkg-buildpackage: info: source version 2.01-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by gregor herrmann <gregoa at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -f \
>   blib/script/rename blib/script/unsafe-rename 
> "/usr/bin/perl" "-MExtUtils::Manifest=fullcheck" -e fullcheck
> rm -f \
>   Rename.bso Rename.def \
>   Rename.exp Rename.x \
>    blib/arch/auto/File/Rename/extralibs.all \
>   blib/arch/auto/File/Rename/extralibs.ld Makefile.aperl \
>   *.a *.o \
>   *perl.core MYMETA.json \
>   MYMETA.yml blibdirs.ts \
>   core core.*perl.*.? \
>   core.[0-9] core.[0-9][0-9] \
>   core.[0-9][0-9][0-9] core.[0-9][0-9][0-9][0-9] \
>   core.[0-9][0-9][0-9][0-9][0-9] libRename.def \
>   mon.out perl \
>   perl perl.exe \
>   perlmain.c pm_to_blib \
>   pm_to_blib.ts so_locations \
>   tmon.out 
> rm -rf \
>   blib 
> mv Makefile Makefile.old > /dev/null 2>&1
> rm -f \
>   Makefile Makefile.old 
> rm -rf \
>   File-Rename-2.01 
> Not in MANIFEST: .pc/.quilt_patches
> Not in MANIFEST: .pc/.quilt_series
> Not in MANIFEST: .pc/.version
> Not in MANIFEST: .pc/applied-patches
> Not in MANIFEST: .pc/autopkgtest.patch/t/File-Rename-script.t
> Not in MANIFEST: .pc/autopkgtest.patch/t/File-Rename-V.t
> Not in MANIFEST: .pc/autopkgtest.patch/t/rename-examples.t
> Not in MANIFEST: .pc/autopkgtest.patch/t/testlib.pl
> Not in MANIFEST: .pc/doc-file-rename.patch/source/rename
> Not in MANIFEST: .pc/doc-file-rename.patch/t/rename-examples.t
> Not in MANIFEST: .pc/doc-file-rename.patch/t/u/rename-examples.t
> Not in MANIFEST: debian/.debhelper/generated/rename/dh_installchangelogs.dch.trimmed
> Not in MANIFEST: debian/.debhelper/generated/rename/installed-by-dh_installdocs
> Not in MANIFEST: debian/.debhelper/generated/rename/installed-by-dh_installexamples
> Not in MANIFEST: debian/.debhelper/generated/rename/installed-by-dh_installman
> Not in MANIFEST: debian/changelog
> Not in MANIFEST: debian/control
> Not in MANIFEST: debian/copyright
> Not in MANIFEST: debian/debhelper-build-stamp
> Not in MANIFEST: debian/files
> Not in MANIFEST: debian/NEWS.Developer
> Not in MANIFEST: debian/patches/autopkgtest.patch
> Not in MANIFEST: debian/patches/doc-file-rename.patch
> Not in MANIFEST: debian/patches/series
> Not in MANIFEST: debian/rename.debhelper.log
> Not in MANIFEST: debian/rename.docs
> Not in MANIFEST: debian/rename.examples
> Not in MANIFEST: debian/rename.links
> Not in MANIFEST: debian/rename.postinst
> Not in MANIFEST: debian/rename.prerm
> Not in MANIFEST: debian/rename.substvars
> Not in MANIFEST: debian/rename/DEBIAN/control
> Not in MANIFEST: debian/rename/DEBIAN/md5sums
> Not in MANIFEST: debian/rename/DEBIAN/postinst
> Not in MANIFEST: debian/rename/DEBIAN/prerm
> Not in MANIFEST: debian/rename/usr/bin/file-rename
> Not in MANIFEST: debian/rename/usr/bin/prename
> Not in MANIFEST: debian/rename/usr/share/doc/rename/changelog.Debian.gz
> Not in MANIFEST: debian/rename/usr/share/doc/rename/changelog.gz
> Not in MANIFEST: debian/rename/usr/share/doc/rename/CONTRIBUTING
> Not in MANIFEST: debian/rename/usr/share/doc/rename/copyright
> Not in MANIFEST: debian/rename/usr/share/doc/rename/examples/rename.pl
> Not in MANIFEST: debian/rename/usr/share/doc/rename/examples/unsafe-rename
> Not in MANIFEST: debian/rename/usr/share/doc/rename/NEWS.Developer.gz
> Not in MANIFEST: debian/rename/usr/share/man/man1/file-rename.1p.gz
> Not in MANIFEST: debian/rename/usr/share/man/man1/prename.1p.gz
> Not in MANIFEST: debian/rename/usr/share/man/man3/File::Rename.3pm.gz
> Not in MANIFEST: debian/rename/usr/share/man/man3/File::Rename::Options.3pm.gz
> Not in MANIFEST: debian/rename/usr/share/man/man3/File::Rename::Unicode.3pm.gz
> Not in MANIFEST: debian/rename/usr/share/perl5/File/Rename.pm
> Not in MANIFEST: debian/rename/usr/share/perl5/File/Rename/Options.pm
> Not in MANIFEST: debian/rename/usr/share/perl5/File/Rename/Unicode.pm
> Not in MANIFEST: debian/rules
> Not in MANIFEST: debian/source/format
> Not in MANIFEST: debian/tests/pkg-perl/smoke-skip
> Not in MANIFEST: debian/watch
> Not in MANIFEST: script/rename
> Not in MANIFEST: script/unsafe-rename
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building rename using existing ./rename_2.01.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  rename-2.01/script/rename
>  rename-2.01/script/unsafe-rename
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/rename_2.01-1.diff.uaOAiY
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/rename_2.01-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.