Bug#1045871: libtrycatch-perl: Fails to build source after successful build

[Lucas Nussbaum]

Source: libtrycatch-perl
Version: 1.003002-3
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libtrycatch-perl
> dpkg-buildpackage: info: source version 1.003002-3
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jelmer Vernooij <jelmer at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> CDBS WARNING:  copyright-check disabled - licensecheck is missing.
> test -x debian/rules
> rm -f debian/stamp-makefile-build debian/stamp-makefile-install
> /usr/bin/make -C . OPTIMIZE="-g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include" LDDLFLAGS="-Wl,-z,relro -shared -L/usr/local/lib -fstack-protector-strong" -k clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> true
> rm -f \
>   TryCatch.bso TryCatch.def \
>   TryCatch.exp TryCatch.x \
>   TryCatch.bs blib/arch/auto/TryCatch/extralibs.all \
>   blib/arch/auto/TryCatch/extralibs.ld Makefile.aperl \
>   *.a *.o \
>   *perl.core MYMETA.json \
>   MYMETA.yml TryCatch.base \
>   TryCatch.bs TryCatch.bso \
>   TryCatch.c TryCatch.def \
>   TryCatch.exp TryCatch.o \
>   TryCatch_def.old blibdirs.ts \
>   core core.*perl.*.? \
>   core.[0-9] core.[0-9][0-9] \
>   core.[0-9][0-9][0-9] core.[0-9][0-9][0-9][0-9] \
>   core.[0-9][0-9][0-9][0-9][0-9] libTryCatch.def \
>   mon.out perl \
>   perl perl.exe \
>   perlmain.c pm_to_blib \
>   pm_to_blib.ts so_locations \
>   tmon.out 
> rm -rf \
>   blib 
> rm -f Makefile.old
> mv Makefile Makefile.old > /dev/null 2>&1
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f debian/stamp-makefile-check
> rm -f debian/copyright_newhints
> rm -f debian/cdbs-install-list debian/cdbs-package-list debian/stamp-copyright-check
> rm -rf "debian/upstream-cruft"
> rm -f debian/stamp-upstream-cruft
> dh_clean 
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libtrycatch-perl using existing ./libtrycatch-perl_1.003002.orig.tar.gz
> dpkg-source: warning: ignoring deletion of file MYMETA.yml, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file MYMETA.json, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  libtrycatch-perl-1.003002/Makefile.old
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libtrycatch-perl_1.003002-3.diff.4na7V2
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libtrycatch-perl_1.003002-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.