Bug#1046326: libmodule-pluggable-perl: Fails to build source after successful build

[Lucas Nussbaum]

Source: libmodule-pluggable-perl
Version: 5.2-4
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libmodule-pluggable-perl
> dpkg-buildpackage: info: source version 5.2-4
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jelmer Vernooij <jelmer at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> "/usr/bin/perl" "-MExtUtils::Manifest=fullcheck" -e fullcheck
> rm -f \
>   Pluggable.bso Pluggable.def \
>   Pluggable.exp Pluggable.x \
>    blib/arch/auto/Module/Pluggable/extralibs.all \
>   blib/arch/auto/Module/Pluggable/extralibs.ld Makefile.aperl \
>   *.a *.o \
>   *perl.core MYMETA.json \
>   MYMETA.yml blibdirs.ts \
>   core core.*perl.*.? \
>   core.[0-9] core.[0-9][0-9] \
>   core.[0-9][0-9][0-9] core.[0-9][0-9][0-9][0-9] \
>   core.[0-9][0-9][0-9][0-9][0-9] libPluggable.def \
>   mon.out perl \
>   perl perl.exe \
>   perlmain.c pm_to_blib \
>   pm_to_blib.ts so_locations \
>   tmon.out 
> rm -rf \
>   blib 
> mv Makefile Makefile.old > /dev/null 2>&1
> rm -f \
>   Makefile Makefile.old 
> rm -rf \
>   Module-Pluggable-5.2 
> No such file: t/lib/EditorJunk/Plugin/Bar.pm~
> Not in MANIFEST: .pc/.quilt_patches
> Not in MANIFEST: .pc/.quilt_series
> Not in MANIFEST: .pc/.version
> Not in MANIFEST: .pc/applied-patches
> Not in MANIFEST: debian/.debhelper/generated/libmodule-pluggable-perl/dh_installchangelogs.dch.trimmed
> Not in MANIFEST: debian/.debhelper/generated/libmodule-pluggable-perl/installed-by-dh_installdocs
> Not in MANIFEST: debian/.debhelper/generated/libmodule-pluggable-perl/installed-by-dh_installman
> Not in MANIFEST: debian/changelog
> Not in MANIFEST: debian/control
> Not in MANIFEST: debian/copyright
> Not in MANIFEST: debian/debhelper-build-stamp
> Not in MANIFEST: debian/files
> Not in MANIFEST: debian/libmodule-pluggable-perl.substvars
> Not in MANIFEST: debian/libmodule-pluggable-perl/DEBIAN/control
> Not in MANIFEST: debian/libmodule-pluggable-perl/DEBIAN/md5sums
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/doc/libmodule-pluggable-perl/changelog.Debian.gz
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/doc/libmodule-pluggable-perl/changelog.gz
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/doc/libmodule-pluggable-perl/copyright
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/man/man3/Devel::InnerPackage.3pm.gz
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/man/man3/Module::Pluggable.3pm.gz
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/man/man3/Module::Pluggable::Object.3pm.gz
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/perl5/Devel/InnerPackage.pm
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/perl5/Module/Pluggable.pm
> Not in MANIFEST: debian/libmodule-pluggable-perl/usr/share/perl5/Module/Pluggable/Object.pm
> Not in MANIFEST: debian/rules
> Not in MANIFEST: debian/source/format
> Not in MANIFEST: debian/upstream/metadata
> Not in MANIFEST: debian/watch
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libmodule-pluggable-perl using existing ./libmodule-pluggable-perl_5.2.orig.tar.gz
> dpkg-source: warning: file libmodule-pluggable-perl-5.2/t/lib/OddTest/Plugin/-Dodgy.pm has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  libmodule-pluggable-perl-5.2/t/lib/OddTest/Plugin/-Dodgy.pm
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libmodule-pluggable-perl_5.2-4.diff.9kwoHQ
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libmodule-pluggable-perl_5.2-4_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.