Bug#1048176: libxml-twig-perl: Fails to build source after successful build

[Lucas Nussbaum]

Source: libxml-twig-perl
Version: 1:3.52-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> --------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libxml-twig-perl
> dpkg-buildpackage: info: source version 1:3.52-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jelmer Vernooij <jelmer at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -f \
>   blib/script/xml_grep blib/script/xml_merge \
>   blib/script/xml_pp blib/script/xml_spellcheck \
>   blib/script/xml_split 
> "/usr/bin/perl" "-MExtUtils::Manifest=fullcheck" -e fullcheck
> rm -f \
>   Twig.bso Twig.def \
>   Twig.exp Twig.x \
>    blib/arch/auto/XML/Twig/extralibs.all \
>   blib/arch/auto/XML/Twig/extralibs.ld Makefile.aperl \
>   *.a *.o \
>   *perl.core MYMETA.json \
>   MYMETA.yml blibdirs.ts \
>   core core.*perl.*.? \
>   core.[0-9] core.[0-9][0-9] \
>   core.[0-9][0-9][0-9] core.[0-9][0-9][0-9][0-9] \
>   core.[0-9][0-9][0-9][0-9][0-9] libTwig.def \
>   mon.out perl \
>   perl perl.exe \
>   perlmain.c pm_to_blib \
>   pm_to_blib.ts so_locations \
>   tmon.out 
> rm -rf \
>   blib 
> mv Makefile Makefile.old > /dev/null 2>&1
> rm -f \
>   Makefile Makefile.old 
> rm -rf \
>   XML-Twig-3.52 
> No such file: META.json
> Not in MANIFEST: .pc/.quilt_patches
> Not in MANIFEST: .pc/.quilt_series
> Not in MANIFEST: .pc/.version
> Not in MANIFEST: .pc/03_cosmetics.diff/Twig.pm
> Not in MANIFEST: .pc/03_cosmetics.diff/Twig_pm.slow
> Not in MANIFEST: .pc/06_spelling.diff/tools/xml_spellcheck/xml_spellcheck
> Not in MANIFEST: .pc/06_spelling.diff/Twig.pm
> Not in MANIFEST: .pc/06_spelling.diff/Twig_pm.slow
> Not in MANIFEST: .pc/07_691028.diff/tools/xml_grep/xml_grep
> Not in MANIFEST: .pc/applied-patches
> Not in MANIFEST: .pc/CVE-2016-9180.patch/t/CVE-2016-9180.t
> Not in MANIFEST: .pc/CVE-2016-9180.patch/t/CVE-2016-9180.txt
> Not in MANIFEST: .pc/CVE-2016-9180.patch/t/CVE-2016-9180.xml
> Not in MANIFEST: .pc/CVE-2016-9180.patch/Twig_pm.slow
> Not in MANIFEST: debian/.debhelper/generated/libxml-twig-perl/dh_installchangelogs.dch.trimmed
> Not in MANIFEST: debian/.debhelper/generated/libxml-twig-perl/installed-by-dh_install
> Not in MANIFEST: debian/.debhelper/generated/libxml-twig-perl/installed-by-dh_installdocs
> Not in MANIFEST: debian/.debhelper/generated/libxml-twig-perl/installed-by-dh_installman
> Not in MANIFEST: debian/.debhelper/generated/xml-twig-tools/dh_installchangelogs.dch.trimmed
> Not in MANIFEST: debian/.debhelper/generated/xml-twig-tools/installed-by-dh_install
> Not in MANIFEST: debian/.debhelper/generated/xml-twig-tools/installed-by-dh_installdocs
> Not in MANIFEST: debian/.debhelper/generated/xml-twig-tools/installed-by-dh_installman
> Not in MANIFEST: debian/changelog
> Not in MANIFEST: debian/clean
> Not in MANIFEST: debian/control
> Not in MANIFEST: debian/copyright
> Not in MANIFEST: debian/debhelper-build-stamp
> Not in MANIFEST: debian/files
> Not in MANIFEST: debian/libxml-twig-perl.install
> Not in MANIFEST: debian/libxml-twig-perl.substvars
> Not in MANIFEST: debian/libxml-twig-perl/DEBIAN/control
> Not in MANIFEST: debian/libxml-twig-perl/DEBIAN/md5sums
> Not in MANIFEST: debian/libxml-twig-perl/usr/share/doc/libxml-twig-perl/changelog.Debian.gz
> Not in MANIFEST: debian/libxml-twig-perl/usr/share/doc/libxml-twig-perl/changelog.gz
> Not in MANIFEST: debian/libxml-twig-perl/usr/share/doc/libxml-twig-perl/copyright
> Not in MANIFEST: debian/libxml-twig-perl/usr/share/man/man3/XML::Twig.3pm.gz
> Not in MANIFEST: debian/libxml-twig-perl/usr/share/perl5/XML/Twig.pm
> Not in MANIFEST: debian/libxml-twig-perl/usr/share/perl5/XML/Twig/XPath.pm
> Not in MANIFEST: debian/patches/03_cosmetics.diff
> Not in MANIFEST: debian/patches/06_spelling.diff
> Not in MANIFEST: debian/patches/07_691028.diff
> Not in MANIFEST: debian/patches/CVE-2016-9180.patch
> Not in MANIFEST: debian/patches/series
> Not in MANIFEST: debian/rules
> Not in MANIFEST: debian/source/format
> Not in MANIFEST: debian/tests/pkg-perl/smoke-files
> Not in MANIFEST: debian/tests/pkg-perl/syntax-skip
> Not in MANIFEST: debian/tmp/usr/bin/xml_grep
> Not in MANIFEST: debian/tmp/usr/bin/xml_merge
> Not in MANIFEST: debian/tmp/usr/bin/xml_pp
> Not in MANIFEST: debian/tmp/usr/bin/xml_spellcheck
> Not in MANIFEST: debian/tmp/usr/bin/xml_split
> Not in MANIFEST: debian/tmp/usr/share/man/man1/xml_grep.1p
> Not in MANIFEST: debian/tmp/usr/share/man/man1/xml_merge.1p
> Not in MANIFEST: debian/tmp/usr/share/man/man1/xml_pp.1p
> Not in MANIFEST: debian/tmp/usr/share/man/man1/xml_spellcheck.1p
> Not in MANIFEST: debian/tmp/usr/share/man/man1/xml_split.1p
> Not in MANIFEST: debian/tmp/usr/share/man/man3/XML::Twig.3pm
> Not in MANIFEST: debian/tmp/usr/share/perl5/XML/Twig.pm
> Not in MANIFEST: debian/tmp/usr/share/perl5/XML/Twig/XPath.pm
> Not in MANIFEST: debian/upstream/metadata
> Not in MANIFEST: debian/watch
> Not in MANIFEST: debian/xml-twig-tools.install
> Not in MANIFEST: debian/xml-twig-tools.substvars
> Not in MANIFEST: debian/xml-twig-tools/DEBIAN/control
> Not in MANIFEST: debian/xml-twig-tools/DEBIAN/md5sums
> Not in MANIFEST: debian/xml-twig-tools/usr/bin/xml_grep
> Not in MANIFEST: debian/xml-twig-tools/usr/bin/xml_merge
> Not in MANIFEST: debian/xml-twig-tools/usr/bin/xml_pp
> Not in MANIFEST: debian/xml-twig-tools/usr/bin/xml_spellcheck
> Not in MANIFEST: debian/xml-twig-tools/usr/bin/xml_split
> Not in MANIFEST: debian/xml-twig-tools/usr/share/doc/xml-twig-tools/changelog.Debian.gz
> Not in MANIFEST: debian/xml-twig-tools/usr/share/doc/xml-twig-tools/changelog.gz
> Not in MANIFEST: debian/xml-twig-tools/usr/share/doc/xml-twig-tools/copyright
> Not in MANIFEST: debian/xml-twig-tools/usr/share/man/man1/xml_grep.1p.gz
> Not in MANIFEST: debian/xml-twig-tools/usr/share/man/man1/xml_merge.1p.gz
> Not in MANIFEST: debian/xml-twig-tools/usr/share/man/man1/xml_pp.1p.gz
> Not in MANIFEST: debian/xml-twig-tools/usr/share/man/man1/xml_spellcheck.1p.gz
> Not in MANIFEST: debian/xml-twig-tools/usr/share/man/man1/xml_split.1p.gz
> Not in MANIFEST: doc_latin1.xml
> Not in MANIFEST: doc_utf8.xml
> Not in MANIFEST: t/CVE-2016-9180.t
> Not in MANIFEST: t/CVE-2016-9180.txt
> Not in MANIFEST: t/CVE-2016-9180.xml
> Not in MANIFEST: t/error.log
> Not in MANIFEST: tata.txt
> Not in MANIFEST: test_uri
> Not in MANIFEST: tmp
> Not in MANIFEST: tmp_file
> Not in MANIFEST: Twig.pm_bak
> Not in MANIFEST: Twig/XPath.pm_bak
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libxml-twig-perl using existing ./libxml-twig-perl_3.52.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file META.yml, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file META.json, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  libxml-twig-perl-3.52/Twig.pm
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libxml-twig-perl_3.52-2.diff.O3Yl1J
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libxml-twig-perl_3.52-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.