Bug#1057776: dh-make-perl: Incorrect .deb filename is used when --install and --revision are supplied

[gregor herrmann]

On Fri, 08 Dec 2023 11:16:12 +0000, Dan Lewis wrote:

> dh-make-perl correctly builds the .deb file with the supplied revision
> and creates libjson-diffable-perl_0.000002-100_all.deb
> 
> However, it then supplies 'libjson-diffable-perl_0.000002-1_all.deb' to
> dpkg when attempting to install the package. Note the use of a hardcoded
> '-1' revision. This causes the operation to fail with:

> The filename is generated with:
> 
> $debname = sprintf( "%s_%s-1_%s.deb", $self->pkgname, $self->version,
> $archspec );
> 
> Which I believe should instead be:
> 
> $debname = sprintf( "%s_%s_%s.deb", $self->pkgname, $self->pkgversion,
> $archspec );
> 
> $self->pkgversion contains the revision supplied with --revision.

Nice catch, thank you.

And thanks for providing a patch, which I've now applied in git and
which should be included in the next upload unless someone finds any
issues with it which I missed.
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20231208/c01245ee/attachment.sig>