Bug#1032105: pkg-perl-tools: [dpt prepare] gitddiff shouldn't use last tag but last tag in current branch

[gregor herrmann]

On Wed, 01 Mar 2023 07:27:13 +0400, Yadd wrote:

> > > > In lib/dpt-lib.sh, maybe you could replace
> > > >     TAG=$(git rev-list -n1 --tags)
> > > or simply
> > >    TAG=$(git describe --abbrev=0)

> > But this works:
> > 
> >    % git describe --abbrev=0 --match "debian/*" --tags # [1]
> >    debian/1.62-3

> > Maybe, in order to git rid of the separation between native and
> > non-native package, something funky as
> > 
> >    % git describe --abbrev=0 --match "$(gbp config DEFAULT.debian-tag | sed -e 's/%(version)s/*/g;')" --tags # [2]
> >    debian/1.62-3
> > 

> > Alright, maybe we all try out either [1] or [2] a bit?
> > I've updated my .gitconfig and my local version of
> > scripts/lib/dpt-lib.sh to use [2].

> I tried also [2], perfect with all Perl packages I've locally + 1500 nodejs
> packages, works perfectly!

Thanks for trying and reporting back!

I was also quite happy so far -- until I hit a repository with no
debian tags (new package, in this case libjson-schema-modern-perl),
and there I got (at the end of dpt-import-orig):

  Git diff against last Debian tag
  ================================
  fatal: No names found, cannot describe anything.


Directly in the shell:

  % git rev-list -n1 --tags=debian
  %

(No output, exit code 0)

  % git describe --abbrev=0 --match "$(gbp config DEFAULT.debian-tag | sed -e 's/%(version)s/*/g;')" --tags
  fatal: No names found, cannot describe anything.

(Exit code 128)

Not sure what to do here; I mean

  % git describe --abbrev=0 --match "$(gbp config DEFAULT.debian-tag | sed -e 's/%(version)s/*/g;')" --tags 2>/dev/null || true

works but …


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20230301/da521259/attachment.sig>