Bug#1075146: libauthen-sasl-xs-perl: ftbfs with GCC-14; patch ready

[Niko Tyni]

[ Russ: I see from the upstream changelog that you were somewhat involved
  in this package and pointer to integer casts 16 years (!) ago. So I'm
  copying you in case you're still interested enough to have a look :)
  No obligation of course. ]

On Fri, Jul 26, 2024 at 10:26:29PM +0200, Étienne Mollier wrote:
> Control: tags -1 + patch
 
> I pushed a patch[1] to salsa to proceed to targeted changes to
> the libauthen-sasl-xs-perl, but I'm not entirely confident
> touching a library that seems security sensitive.  I'm notably
> feeling a bit bugged by the initial type discrepancy of a
> variable passed to an IV.
> 
> I'll hold my horses a couple of days before upload, in case
> someone is interested to have a look over the weekend.
> 
> [1]: https://salsa.debian.org/perl-team/modules/packages/libauthen-sasl-xs-perl/-/raw/debian/latest/debian/patches/gcc-14.patch?ref_type=heads

Thanks for your work on this.

The explicit casts of the callbacks look good to me FWIW.  But I also
wonder about the pointer to integer cast in XS.xs:1886.

If it's really the right thing to do, I suppose casting to an IV would
be more correct than either int or long int.  But I suspect that the
intention might be to dereference the pointer instead. FWIW I tried that
at home and the test suite still passed, so clearly it's not covering
these parts.

I don't see any reverse dependencies, so removal is also an option.
Particularly as this seems security sensitive and abandoned upstream...
-- 
Niko