Bug#1066249: libmediascan: FTBFS: api_test.c:80:3: error: implicit declaration of function ‘gettimeofday’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: libmediascan
Version: 0~20220401.git.34fc2d-4
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -I../include -I../test -I/usr/local/BerkeleyDB.5.1/include -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o image_test-image_test.o `test -f 'image_test.c' || echo './'`image_test.c
> api_test.c: In function ‘check_mimetypes’:
> api_test.c:80:3: error: implicit declaration of function ‘gettimeofday’ [-Werror=implicit-function-declaration]
>    80 |   gettimeofday(&now, NULL);
>       |   ^~~~~~~~~~~~
> api_test.c:118:83: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long int’ [-Wformat=]
>   118 |         printf("------------------------------------------------------\nTotal MS %d\n", end_count - start_count);
>       |                                                                                  ~^     ~~~~~~~~~~~~~~~~~~~~~~~
>       |                                                                                   |               |
>       |                                                                                   int             long int
>       |                                                                                  %ld
> In file included from image_test.c:4:
> common.h: In function ‘_findbin’:
> common.h:27:5: warning: ignoring return value of ‘getcwd’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>    27 |     getcwd(buf, 1024);
>       |     ^~~~~~~~~~~~~~~~~
> api_test.c: In function ‘main’:
> api_test.c:198:3: error: implicit declaration of function ‘run_unit_tests’ [-Werror=implicit-function-declaration]
>   198 |   run_unit_tests();
>       |   ^~~~~~~~~~~~~~
> In file included from api_test.c:10:
> common.h: In function ‘_findbin’:
> common.h:27:5: warning: ignoring return value of ‘getcwd’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>    27 |     getcwd(buf, 1024);
>       |     ^~~~~~~~~~~~~~~~~
> In file included from /usr/include/CUnit/Basic.h:36,
>                  from test_background.c:24:
> test_background.c: In function ‘test_background_api’:
> test_background.c:12:16: error: implicit declaration of function ‘mkdir’; did you mean ‘_mkdir’? [-Werror=implicit-function-declaration]
>    12 | #define _mkdir mkdir
>       |                ^~~~~
> test_background.c:203:20: note: in expansion of macro ‘_mkdir’
>   203 |         CU_ASSERT( _mkdir(test_path) != -1 );
>       |                    ^~~~~~
> test_background.c: In function ‘test_async_api’:
> test_background.c:822:3: error: implicit declaration of function ‘gettimeofday’ [-Werror=implicit-function-declaration]
>   822 |   gettimeofday(&now, NULL);
>       |   ^~~~~~~~~~~~
> test.c: In function ‘test_ms_scan_6’:
> test.c:356:15: warning: extra tokens at end of #endif directive [-Wendif-labels]
>   356 |         #endif;
>       |               ^
> test.c: In function ‘TouchFile’:
> test.c:512:3: error: implicit declaration of function ‘gettimeofday’ [-Werror=implicit-function-declaration]
>   512 |   gettimeofday(&now, NULL);
>       |   ^~~~~~~~~~~~
> test.c:513:3: error: implicit declaration of function ‘utimes’; did you mean ‘ctime’? [-Werror=implicit-function-declaration]
>   513 |   utimes(filename  , &now);
>       |   ^~~~~~
>       |   ctime
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:658: api_test-api_test.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/libmediascan_0~20220401.git.34fc2d-4_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.