Bug#1097165: libauthen-tacacsplus-perl: ftbfs with GCC-15

[Matthias Klose]

Package: src:libauthen-tacacsplus-perl
Version: 0.28-2
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/libauthen-tacacsplus-perl_0.28-2_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      | ^~~~~~~~~~
utils.c:67:9: error: too many arguments to function ‘report’; expected 0, have 3
   67 |         report(LOG_ERR, "realloc %d failure", size);
      |         ^~~~~~ ~~~~~~~
tac_plus.h:628:13: note: declared here
  628 | extern void report();
      |             ^~~~~~
utils.c: In function ‘tac_strdup’:
utils.c:74:1: warning: old-style function definition [-Wold-style-definition]
   74 | tac_strdup(p)
      | ^~~~~~~~~~
utils.c:76:1: error: number of arguments doesn’t match prototype
   76 | {
      | ^
tac_plus.h:636:14: error: prototype declaration
  636 | extern char *tac_strdup();
      |              ^~~~~~~~~~
utils.c:80:9: error: too many arguments to function ‘report’; expected 0, have 2
   80 |         report(LOG_ERR, "strdup allocation failure");
      |         ^~~~~~ ~~~~~~~
tac_plus.h:628:13: note: declared here
  628 | extern void report();
      |             ^~~~~~
utils.c: In function ‘tac_make_string’:
utils.c:87:1: warning: old-style function definition [-Wold-style-definition]
   87 | tac_make_string(p, len)
      | ^~~~~~~~~~~~~~~
utils.c:90:1: error: number of arguments doesn’t match prototype
   90 | {
      | ^
tac_plus.h:637:14: error: prototype declaration
  637 | extern char *tac_make_string();
      |              ^~~~~~~~~~~~~~~
utils.c:101:23: error: too many arguments to function ‘tac_malloc’; expected 0, have 1
  101 |     string = (char *) tac_malloc(new_len);
      |                       ^~~~~~~~~~ ~~~~~~~
utils.c:33:1: note: declared here
   33 | tac_malloc(size)
      | ^~~~~~~~~~
utils.c: In function ‘tac_find_substring’:
utils.c:112:1: warning: old-style function definition [-Wold-style-definition]
  112 | tac_find_substring(substring, string)
      | ^~~~~~~~~~~~~~~~~~
utils.c:114:1: error: number of arguments doesn’t match prototype
  114 | {
      | ^
tac_plus.h:638:14: error: prototype declaration
  638 | extern char *tac_find_substring();
      |              ^~~~~~~~~~~~~~~~~~
utils.c: In function ‘tac_lockfd’:
utils.c:185:1: warning: old-style function definition [-Wold-style-definition]
  185 | tac_lockfd(filename,lockfd)
      | ^~~~~~~~~~
x86_64-linux-gnu-gcc -c   -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/libauthen-tacacsplus-perl-0.28=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2   -DVERSION=\"0.28\" -DXS_VERSION=\"0.28\" -fPIC "-I/usr/lib/x86_64-linux-gnu/perl/5.40/CORE"   TacacsPlus.c
make[2]: *** [Makefile:330: utils.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/libauthen-tacacsplus-perl-0.28/tacpluslib'
make[1]: *** [Makefile:1283: tacpluslib/libtacplus.a] Error 2
make[1]: *** Waiting for unfinished jobs....
TacacsPlus.xs: In function ‘not_here’:
TacacsPlus.xs:16:1: warning: old-style function definition [-Wold-style-definition]
   16 | not_here(s)
      | ^~~~~~~~
TacacsPlus.xs: In function ‘constant’:
TacacsPlus.xs:24:1: warning: old-style function definition [-Wold-style-definition]
   24 | constant(name, arg)
      | ^~~~~~~~
make[1]: Leaving directory '/build/reproducible-path/libauthen-tacacsplus-perl-0.28'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:6: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2