Bug#1117095: libfirefox-marionette-perl: Build-Depends on dbus-x11 (dbus-launch) and relies on X11 autolaunching

[Simon McVittie]

Source: libfirefox-marionette-perl
Version: 1.65-1
Severity: normal
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

This package build-depends on dbus-x11, and seems to be relying on X11 
autolaunching to get a D-Bus session bus for its build-time tests: it 
does not seem to explicitly invoke dbus-launch or dbus-run-session.

D-Bus X11 autolaunching is a poorly-understood legacy code path which 
should be avoided where possible. Instead, please build-depend on 
dbus-daemon and invoke a temporary D-Bus session bus explicitly, more 
like this (untested):

override_dh_auto_test:
	NO_NETWORK=1 RES_OPTIONS=attempts:0 http_proxy= \
	xvfb-run -a \
	dbus-run-session -- \
	dh_auto_test -- TEST_FILES="$(TEST_FILES)"

This only requires a B-D on dbus-daemon <!nocheck>, which is a smaller 
dependency than dbus-x11 and contains more robust code.

Thanks,
    smcv