Bug#1141622: libauthen-libwrap-perl: invalid XS comment syntax, breaks with Perl 5.44

[Niko Tyni]

Package: libauthen-libwrap-perl
Version: 0.23-2
Severity: normal
Tags: patch
User: debian-perl at lists.debian.org
Usertags: perl-5.44-transition

This package fails to build with Perl 5.44.0-RC1 (not in Debian quite
yet), because lib/Authen/Libwrap.xs has a C style comment (/* ... */)
at the end where only XS style comments (# ...) are allowed.

The ExtUtils::ParseXS module, which does the parsing, was
largely rewritten during the Perl 5.44 development cycle,
and the new versions consider this a hard error.

  Building Authen-Libwrap
  Error: unrecognised line: '/ * EOF * /' in Libwrap.xs, line 32
    (possible start of a truncated XSUB definition?)

The perlxs documentation in 5.44.0-RC1 has this to say on the subject:

  An XSUB ends when /\n\n\S/ is encountered: i.e. a blank line followed
  by something on column one. (This is why it's recommended to indent
  XSUB-scoped keywords.) If the thing at column one matches any of the
  items which can appear in between XSUBs (such as file-scoped keywords)
  then it, and any subsequent lines, are processed as such. Anything
  starting on column one which isn't otherwise recognised, is interpreted
  as the first line of the next XSUB definition. In particular it is
  interpreted as the return type of the XSUB: this can lead to weird
  errors when something is unexpectedly interpreted as the start of a
  new XSUB, such as /* */, which isn't valid in the XS half of the file
  apart from within code blocks.

The attached trivial patch makes libauthen-libwrap-perl build with
both Perl 5.40 and Perl 5.44.
-- 
Niko Tyni	ntyni at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-xs-comment-syntax.patch
Type: text/x-diff
Size: 591 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20260707/42d7f357/attachment.patch>