Bug#1151887: libdbd-pg-perl: debci regression with Perl 5.44: Use of "goto" to jump into a construct is no longer permitted

[Niko Tyni]

Control: tag -1 patch

On Sat, Oct 24, 2026 at 11:49:27AM +0300, Niko Tyni wrote:
> Package: libdbd-pg-perl
> Version: 3.21.2-1
> Severity: important
> User: debian-perl at lists.debian.org
> Usertags: perl-5.44-transition
> 
> This package fails its debci checks with Perl 5.44 (currently in experimental.)
> 
>  t/02attribs.t .......... 
>  Use of "goto" to jump into a construct is no longer permitted at t/dbdpg_test_setup.pl line 271.
>  Dubious, test returned 2 (wstat 512, 0x200)
>  No subtests run 
> 
> The package needed a rebuild for Perl 5.44, and the test suite was
> successful at that time.  Presumably this only happens when DBDPG_INITDB
> is set (see debian/tests/pkg-perl/smoke-env).

The problem seems to be jumping into the INITDB label that
is inside the GETHANDLE: {} block.

I think these are functionally equivalent:

	GETHANDLE: {
		INITDB: foo();
		last GETHANDLE unless bar();
	}
	goto INITDB;

vs.

	GETHANDLE_START:
		INITDB: foo();
		goto GETHANDLE_END unless bar();

	GETHANDLE_END:
	goto INITDB;


Proposed patch attached, this seems to work for me.
-- 
Niko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-test-setup-on-Perl-5.44-when-DBDPG_INITDB-is-set.patch
Type: text/x-diff
Size: 6980 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20261102/066de013/attachment.patch>