Sorry, when I refer to 2.* code I mean to refer to 1.20+ code.<br><br clear="all">Paul Beardsell<br>Paul@Beardsell.com<br>
<br><br><div class="gmail_quote">2009/10/20 Paul Beardsell <span dir="ltr"><<a href="mailto:paul@beardsell.com">paul@beardsell.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Please refer <a href="http://rt.cpan.org/Public/Bug/Display.html?id=16579" target="_blank">http://rt.cpan.org/Public/Bug/Display.html?id=16579</a><br><br>I've been looking at the source code of various versions of SQL::Statement.<br>
<br>
Ty suggested a number of patches to address the performance problems I
reported. He supplied a patch file.<br>
<br>
My bug report "#317518: New version of libsql-statement-perl is very, very much slower" has been closed and the reasoning goes as follows. The last Debian version was 1.5, the next version in Debian is 2.*, and the patch is reported as being applied in version 1.16.2. I can't find the 1.16.2 code but I have found the 1.18 code. Much of the patch is *not* to be found in 1.18<br>
<br>The differences from 1.* to 2.* code are too great for me to get my head around in a short time, but I suspect if the patch is NOT to be found in 1.18, and it was reported as beinbg done in 1.16, that it is also not to be found in 2.*<div class="im">
<br>
<br clear="all">Paul Beardsell<br>Paul@Beardsell.com<br>
<br><br></div><div class="gmail_quote">2009/10/20 Jens Rehsack <span dir="ltr"><<a href="mailto:rehsack@googlemail.com" target="_blank">rehsack@googlemail.com</a>></span><div><div></div><div class="h5"><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
2009/10/20 Jeff Zucker <<a href="mailto:jeff@vpservices.com" target="_blank">jeff@vpservices.com</a>>:<br>
<div>> Greg,<br>
><br>
> I am no longer the primary maintainer of SQL::Statement, I am cc'ing Jens<br>
> Rehsack, the new primary maintainer.<br>
<br>
</div>Maybe giving me the maintainership instead adding me as Co-Maintainer<br>
(and adding you back as Co-Maintainer) would stop that confusion?<br>
I don't think - I think the people just taking the first name they<br>
find and neither<br>
look into the release history nor in the ChangeLog.<br>
<div><br>
> In comparing the pre 1.-0 release to current releases you are comparing<br>
> apples to oranges since the pre-1.0 release supported almost no actual SQL<br>
> while the post releases have gotten successively richer in the SQL they<br>
> support. My $0.02 is that if speed, rather than compatibility with other<br>
> SQL implementations is a concern, one is best off using Text::CSV_XS<br>
> directly or importing the data into SQLite or another db for processing.<br>
> OTOH, it's possible Jens has or will be introducing speed improvements I<br>
> know nothing about.<br>
<br>
</div>Jens plans to re-write the entire module when he find enough time or enough<br>
sponsors. As long as neither is present, Jens still fixes the current issues.<br>
I don't plan to invest much time and effort into the current implementation,<br>
because currently there're to many side-effects and duplicated code in the<br>
module.<br>
<div><br>
> One other consideration - all of the drivers (DBD::CSV, etc.) that use<br>
> SQL::Statement are also able to use DBI::SQL::Nano (comes with the DBI<br>
> distro) which has about the same feature set as the pre 1-0 release and<br>
> which can be much faster than the full SQL::Statement for some tasks.<br>
<br>
</div>Nope! AFAIK (and what I've seen from Merijn) DBD::CSV requires SQL::Statement.<br>
<br>
Best regards,<br>
Jens<br>
<br>
> --<br>
<div><div></div><div>> Jeff<br>
><br>
> <a href="mailto:rehsack@googlemail.com" target="_blank">rehsack@googlemail.com</a><br>
><br>
> On Tue, Oct 20, 2009 at 2:35 AM, Paul Beardsell <<a href="mailto:paul@beardsell.com" target="_blank">paul@beardsell.com</a>> wrote:<br>
>><br>
>> Jeff,<br>
>><br>
>> (cc Greg, the Debian maintainer of libsql-statement-perl)<br>
>><br>
>> I understand you are perhaps the developer/maintainer or primary contact<br>
>> re the Perl package SQL::Statement.<br>
>><br>
>> I am an enthusuastic user of the pre 1.0 release of SQL::Statement as<br>
>> found in Debian "Woody" Linux. 1.0 and later releases of SQL::Statement in<br>
>> more current versions of Debian Linux have been found by me to be much, much<br>
>> slower than the pre-1.0 releases on text CSV databases of only 2000 rows. I<br>
>> reported this bug to Debian and they now say it is "fixed" but no evidence<br>
>> as to what has been done is presented other than to say they have accepted a<br>
>> new upstream release, 1.22.<br>
>><br>
>> I understand the reason for the performance fall was the re-write of<br>
>> C-code into pure Perl. Fine, but if that is the reason I am sure that you<br>
>> have not re-introduced the old C code! I also note a number of performance<br>
>> improvements were reported between 1.11 and 1.14 but *my* benchmarking<br>
>> showed a 20% reduction in speed between from 1.11 to 1.14.<br>
>><br>
>> (1) Are you aware of any changes made to SQL::Statement between 1.14 and<br>
>> 1.22 which may have restored the excellent performance of the pre-1.0<br>
>> releases of SQL::Statement?<br>
>><br>
>> (2) It also strikes me that possibly the problem is not in SQL::Statement<br>
>> but in DBD::CSV. What do you think?<br>
>><br>
>> Regards (and thanks for an [otherwise!] excellent package),<br>
>> Paul<br>
>><br>
>> Paul Beardsell<br>
>> Paul@Beardsell.com<br>
>><br>
>><br>
>> 2009/10/20 Paul Beardsell <<a href="mailto:paul@beardsell.com" target="_blank">paul@beardsell.com</a>><br>
>>><br>
>>> Hi, I have been notified that the bug I reported "#317518: New version of<br>
>>> libsql-statement-perl is very, very much slower" is reported as fixed and<br>
>>> has been closed by you. The notification says that details of the changes<br>
>>> are to be found "below" but whereas I see lots of admin detail I nothing of<br>
>>> what has been done to supposedly restore the previous performance of this<br>
>>> package. What has been done? How do I find this out?<br>
>>><br>
>>> Thanks,<br>
>>> Paul<br>
>>><br>
>>> Paul Beardsell<br>
>>> Paul@Beardsell.com<br>
>>><br>
>>><br>
>>> 2009/10/19 Debian Bug Tracking System <<a href="mailto:owner@bugs.debian.org" target="_blank">owner@bugs.debian.org</a>><br>
>>>><br>
>>>> This is an automatic notification regarding your Bug report<br>
>>>> which was filed against the libsql-statement-perl package:<br>
>>>><br>
>>>> #317518: New version of libsql-statement-perl is very, very much slower<br>
>>>><br>
>>>> It has been closed by gregor herrmann <<a href="mailto:gregoa@debian.org" target="_blank">gregoa@debian.org</a>>.<br>
>>>><br>
>>>> Their explanation is attached below along with your original report.<br>
>>>> If this explanation is unsatisfactory and you have not received a<br>
>>>> better one in a separate message then please contact gregor herrmann<br>
>>>> <<a href="mailto:gregoa@debian.org" target="_blank">gregoa@debian.org</a>> by<br>
>>>> replying to this email.<br>
>>>><br>
>>>><br>
>>>> --<br>
>>>> 317518: <a href="http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=317518" target="_blank">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=317518</a><br>
>>>> Debian Bug Tracking System<br>
>>>> Contact <a href="mailto:owner@bugs.debian.org" target="_blank">owner@bugs.debian.org</a> with problems<br>
>>>><br>
>>>><br>
>>>> ---------- Forwarded message ----------<br>
>>>> From: gregor herrmann <<a href="mailto:gregoa@debian.org" target="_blank">gregoa@debian.org</a>><br>
>>>> To: <a href="mailto:317518-close@bugs.debian.org" target="_blank">317518-close@bugs.debian.org</a><br>
>>>> Date: Mon, 19 Oct 2009 17:03:41 +0000<br>
>>>> Subject: Bug#317518: fixed in libsql-statement-perl 1.22-1<br>
>>>> Source: libsql-statement-perl<br>
>>>> Source-Version: 1.22-1<br>
>>>><br>
>>>> We believe that the bug you reported is fixed in the latest version of<br>
>>>> libsql-statement-perl, which is due to be installed in the Debian FTP<br>
>>>> archive:<br>
>>>><br>
>>>> libsql-statement-perl_1.22-1.diff.gz<br>
>>>> to<br>
>>>> pool/main/libs/libsql-statement-perl/libsql-statement-perl_1.22-1.diff.gz<br>
>>>> libsql-statement-perl_1.22-1.dsc<br>
>>>> to<br>
>>>> pool/main/libs/libsql-statement-perl/libsql-statement-perl_1.22-1.dsc<br>
>>>> libsql-statement-perl_1.22-1_all.deb<br>
>>>> to<br>
>>>> pool/main/libs/libsql-statement-perl/libsql-statement-perl_1.22-1_all.deb<br>
>>>> libsql-statement-perl_1.22.orig.tar.gz<br>
>>>> to<br>
>>>> pool/main/libs/libsql-statement-perl/libsql-statement-perl_1.22.orig.tar.gz<br>
>>>><br>
>>>><br>
>>>><br>
>>>> A summary of the changes between this version and the previous one is<br>
>>>> attached.<br>
>>>><br>
>>>> Thank you for reporting the bug, which will now be closed. If you<br>
>>>> have further comments please address them to <a href="mailto:317518@bugs.debian.org" target="_blank">317518@bugs.debian.org</a>,<br>
>>>> and the maintainer will reopen the bug report if appropriate.<br>
>>>><br>
>>>> Debian distribution maintenance software<br>
>>>> pp.<br>
>>>> gregor herrmann <<a href="mailto:gregoa@debian.org" target="_blank">gregoa@debian.org</a>> (supplier of updated<br>
>>>> libsql-statement-perl package)<br>
>>>><br>
>>>> (This message was generated automatically at their request; if you<br>
>>>> believe that there is a problem with it please contact the archive<br>
>>>> administrators by mailing <a href="mailto:ftpmaster@debian.org" target="_blank">ftpmaster@debian.org</a>)<br>
>>>><br>
>>>><br>
>>>> -----BEGIN PGP SIGNED MESSAGE-----<br>
>>>> Hash: SHA1<br>
>>>><br>
>>>> Format: 1.8<br>
>>>> Date: Mon, 19 Oct 2009 18:12:55 +0200<br>
>>>> Source: libsql-statement-perl<br>
>>>> Binary: libsql-statement-perl<br>
>>>> Architecture: source all<br>
>>>> Version: 1.22-1<br>
>>>> Distribution: unstable<br>
>>>> Urgency: low<br>
>>>> Maintainer: Debian Perl Group<br>
>>>> <<a href="mailto:pkg-perl-maintainers@lists.alioth.debian.org" target="_blank">pkg-perl-maintainers@lists.alioth.debian.org</a>><br>
>>>> Changed-By: gregor herrmann <<a href="mailto:gregoa@debian.org" target="_blank">gregoa@debian.org</a>><br>
>>>> Description:<br>
>>>> libsql-statement-perl - Perl SQL parsing and processing engine<br>
>>>> Closes: 317518 531238<br>
>>>> Changes:<br>
>>>> libsql-statement-perl (1.22-1) unstable; urgency=low<br>
>>>> .<br>
>>>> [ gregor herrmann ]<br>
>>>> * debian/control: Changed: Switched Vcs-Browser field to ViewSVN<br>
>>>> (source stanza).<br>
>>>> * debian/control: Added: ${misc:Depends} to Depends: field.<br>
>>>> .<br>
>>>> [ Rene Mayorga ]<br>
>>>> * New upstream release<br>
>>>> * debian/control:<br>
>>>> + wrap long lines<br>
>>>> + add myself to uploaders<br>
>>>> + add libdbd-csv-perl to B-D-I<br>
>>>> * debian/rules; updated using dh-make-perl<br>
>>>> * debhelper and debian/compat set to 7<br>
>>>> * libsql-statement-perl.doc; keep README<br>
>>>> * debian/copyright:<br>
>>>> + use (new)format<br>
>>>> + add copyright years to upstream<br>
>>>> + add upstream's missing copyright statement<br>
>>>> + split copyright stanzas for debian/*<br>
>>>> .<br>
>>>> [ Ryan Niebur ]<br>
>>>> * New upstream release<br>
>>>> * Add myself to uploaders<br>
>>>> * Add libclone-perl and libparams-util-perl to B-D-I and Depends<br>
>>>> * Update ryan52's email address<br>
>>>> .<br>
>>>> [ Nathan Handler ]<br>
>>>> * debian/watch: Update to ignore development releases.<br>
>>>> .<br>
>>>> [ gregor herrmann ]<br>
>>>> * Change my email address.<br>
>>>> * New upstream release 1.22.<br>
>>>> + update dependencies<br>
>>>> + closes: #531238, #317518<br>
>>>> + remove patch and quilt framework, RT#13080 (Debian bug #311788) is<br>
>>>> resolved<br>
>>>> + update and compact copyright<br>
>>>> * Minimize debian/rules, adjust build deps.<br>
>>>> * Set Standards-Version to 3.8.3; remove version from perl dependency.<br>
>>>> * Rename debian/README.update.Debian to debian/README.Debian, add<br>
>>>> debian/NEWS about possible problems, install upstream Todo.<br>
>>>> Checksums-Sha1:<br>
>>>> 8ea04c5a0f6c41a289302357ee075b1f6270c54a 1580<br>
>>>> libsql-statement-perl_1.22-1.dsc<br>
>>>> fbab6660699617cc0c21102e08e6e88cbe02dae0 100115<br>
>>>> libsql-statement-perl_1.22.orig.tar.gz<br>
>>>> cc274e2d425832bd5b9a2c9ad9cfb6741a361ccd 4785<br>
>>>> libsql-statement-perl_1.22-1.diff.gz<br>
>>>> a31143c90b288c381e11ef84a3a22022274773f3 150546<br>
>>>> libsql-statement-perl_1.22-1_all.deb<br>
>>>> Checksums-Sha256:<br>
>>>> 3137632930c07f758f066f59261011bcb585e1dd337aad6d8f050d72cbf23d6b 1580<br>
>>>> libsql-statement-perl_1.22-1.dsc<br>
>>>> 56fa1b3875abaa474441857a4ebbd8fbcaa0112527bc4c764d37ca782bd9d467 100115<br>
>>>> libsql-statement-perl_1.22.orig.tar.gz<br>
>>>> 7da01f746f20b4fec71623a190cb30601fbb8cdc90d8c6674026e1d1d99a918d 4785<br>
>>>> libsql-statement-perl_1.22-1.diff.gz<br>
>>>> 3b47ce8dc7e66a1d6f51cf9e5571f663f59c952925b59d0fe1b763157f6668aa 150546<br>
>>>> libsql-statement-perl_1.22-1_all.deb<br>
>>>> Files:<br>
>>>> 40fe0dbc79fdd60c2861260ef228936b 1580 perl optional<br>
>>>> libsql-statement-perl_1.22-1.dsc<br>
>>>> 78c591dc36b6e011abd59717f6450870 100115 perl optional<br>
>>>> libsql-statement-perl_1.22.orig.tar.gz<br>
>>>> 5bbe6fca7e17704af4cfb8728348226b 4785 perl optional<br>
>>>> libsql-statement-perl_1.22-1.diff.gz<br>
>>>> 5ddc15298d77f8620710b60f0d08e3eb 150546 perl optional<br>
>>>> libsql-statement-perl_1.22-1_all.deb<br>
>>>><br>
>>>> -----BEGIN PGP SIGNATURE-----<br>
>>>> Version: GnuPG v1.4.10 (GNU/Linux)<br>
>>>><br>
>>>> iEYEARECAAYFAkrckHAACgkQOzKYnQDzz+SpTQCfSo3kzS3vV0B+A7DVhLlNKIaK<br>
>>>> kKEAn1M2KOJXT+RHhFNju2VIYBe/GlpH<br>
>>>> =0IYS<br>
>>>> -----END PGP SIGNATURE-----<br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> ---------- Forwarded message ----------<br>
>>>> From: Paul Beardsell <Paul@Beardsell.com><br>
>>>> To: Debian Bug Tracking System <<a href="mailto:submit@bugs.debian.org" target="_blank">submit@bugs.debian.org</a>><br>
>>>> Date: Sat, 09 Jul 2005 12:00:27 +0100<br>
>>>> Subject: New version of libsql-statement-perl is very, very much slower<br>
>>>> Package: libsql-statement-perl<br>
>>>> Version: 1.11-1<br>
>>>> Severity: normal<br>
>>>><br>
>>>><br>
>>>> I depend upon libsql-statement-perl to manage small<br>
>>>> plain text databases of approx 2000 rows. Performance<br>
>>>> was fine in the version of libsql-statement-perl<br>
>>>> which came with woody but the newer version in sarge<br>
>>>> is very, very much slower. I understand this may<br>
>>>> be because because C code in the former version has<br>
>>>> been replaced with Perl code. Fine, but this makes<br>
>>>> the package nearly unusable for me because of the<br>
>>>> performance problem. I do not want to have to switch<br>
>>>> over to SQLite.<br>
>>>><br>
>>>> -- System Information:<br>
>>>> Debian Release: 3.1<br>
>>>> APT prefers testing<br>
>>>> APT policy: (70, 'testing'), (60, 'unstable')<br>
>>>> Architecture: i386 (i686)<br>
>>>> Kernel: Linux 2.6.8-2-686<br>
>>>> Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)<br>
>>>><br>
>>>> Versions of packages libsql-statement-perl depends on:<br>
>>>> ii perl 5.8.4-8 Larry Wall's Practical<br>
>>>> Extraction<br>
>>>><br>
>>>> -- no debconf information<br>
>>>><br>
>>>><br>
>>><br>
>><br>
><br>
><br>
</div></div></blockquote></div></div></div><br>
</blockquote></div><br>