No subject

Mon Jan 7 23:10:01 UTC 2008

maintenance, but with the current situation the performance has increased
and I am more free to do what I want.
I'm open for suggestions, though...

> That way, qtpfsgui
> would automatically benefit from any improvements, bugfixes, etc. of
> pfstools and pfstmo.
>
> If you're doing some custom modifications to the PFS stream, it could be
> replaced by writing another PFS-tool to do that job - which could be
> included either in pfstools, if upstream agrees, or qtpfsgui.
>
> This is not meant to be any form of criticism - it's just some ideas
> that came to my mind and that I'd like to discuss :-)
>
> TIA,
> Sebastian
>
> --
> Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
>
> Those who would give up Essential Liberty to purchase a little Temporary
> Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHqKdUEFEKc4UBx/wRAmmPAKCQJ1t2V+fl0N7Vg7LpQuBUE5L+8gCeJNv6
> gm7+CRqFHaIDG9DYZpxUaZw=
> =OoXf
> -----END PGP SIGNATURE-----
>
>

------=_Part_8453_2723321.1202239817559
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<br><br><div class="gmail_quote">On Feb 5, 2008 7:13 PM, Sebastian Harl &lt;<a href="mailto:sh at tokkee.org" target="_blank">sh at tokkee.org</a>&gt; wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

Hi Giuseppe, (Cc&#39;ing pkg-phototools-devel, please keep the list in Cc when replying.) Disclaimer: I did not have a look at the source code so far, nor did I use qtpfsgui very often yet. ;-) I was wondering how the general architecture of qtpfsgui looks like.

I.e.: How does it access the functionality provided by pfstools and pfstmo? How does it exchange data between different parts of the program? Giuseppe, could you please provide a very simple overview? I&#39;d really appreciate that.</blockquote>

<div> Hi Sebastian &amp; list, the main data type that gets exchanged between the different parts of the program is a pointer to a structure which was inherited by pfstools, a pfs::Frame. If we discard the metadata a pfs::Frame basically holds 3 matrices of floats, one for each color channel.

The color space is usually either XYZ or sRBG. (The pfs stream is documented in a pdf ffrom the pfstools project) </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

The main reason for asking: IIrc, you reuse / modify the code of pfstools and pfstmo to generate one large, monolithic binary. That would mean that basically all of the code gets duplicated - including any bugs

- which makes maintenance twice as much work.</blockquote><div><br>yes, exactly.<br>&nbsp;<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

Now, I was wondering if it would be possible to use the pfstool / pfstmo binaries directly - i.e. do fork() and exec() from qtpfsgui. qtpfsgui itself would just need to be the glue to keep it all together and probably take care of some

temporary files. Does that sound reasonable to you?</blockquote><div> Yes, it is reasonable, and it actually was the default behavior in the more recent version of qtpfsgui. I had 2 problems, though: 1) pfstools&#39; upstream did not want to integrate several important changes. 
2) Performance: buffering the stdout and piping that in again was a terrible drawback. From a design standpoint duplicating the code requires twice the maintenance, but with the current situation the performance has increased and I am more free to do what I want. 
I&#39;m open for suggestions, though... &nbsp;</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 That way, qtpfsgui would automatically benefit from any improvements, bugfixes, etc. of pfstools and pfstmo. If you&#39;re doing some custom modifications to the PFS stream, it could be replaced by writing another PFS-tool to do that job - which could be

included either in pfstools, if upstream agrees, or qtpfsgui.<br><br>This is not meant to be any form of criticism - it&#39;s just some ideas<br>that came to my mind and that I&#39;d like to discuss :-)<br><br>TIA,<br>Sebastian<br>

<font color="#888888"><br>--<br>Sebastian &quot;tokkee&quot; Harl +++ GnuPG-ID: 0x8501C7FC +++ <a href="http://tokkee.org/" target="_blank">http://tokkee.org/</a><br><br>Those who would give up Essential Liberty to purchase a little Temporary<br>

Safety, deserve neither Liberty nor Safety. &nbsp; &nbsp; &nbsp; &nbsp; -- Benjamin Franklin -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHqKdUEFEKc4UBx/wRAmmPAKCQJ1t2V+fl0N7Vg7LpQuBUE5L+8gCeJNv6

gm7+CRqFHaIDG9DYZpxUaZw=<br>=OoXf<br>-----END PGP SIGNATURE-----<br><br></blockquote></div><br>

------=_Part_8453_2723321.1202239817559--