[Pkg-phototools-devel] openjpeg FTBFS on alpha

[Cyril Brulebois]

On 26/05/2008, Robin Cornelius wrote:
> Hi everyone,

Hello,

> Just flagging up the fact that openjpeg failed on the autobuilders
> alpha platform [1]. I had actualy missed this and only just spotted it
> ;-(

you might also want to open a bug, if that's not fixed within short
delays.

> Snippet of offence from the autobuilder log :-
> 
> gcc   compat/getopt.c index.c convert.c j2k_to_image.c -o j2k_to_image
> -L.. -lopenjpeg -I ../libopenjpeg/ -lm -ltiff
> In file included from j2k_to_image.c:40:
> dirent.h:122:5: error: #error "not implemented"
> dirent.h:673:3: error: #error "missing dirent interface"
> j2k_to_image.c: In function 'get_num_images':
> j2k_to_image.c:144: error: 'DIR' undeclared (first use in this function)
> 
> Will have a look as soon as is possible. As we have not completed a
> successful build on alpha yet this is not RC but it needs addressing.

At first glance: through #if's, variables usually set by ./configure are
checked (HAVE_*). If not there, a check of various features is done by
checking the arch, and a list of known missing features, that's why we
end up with:
# elif defined(__alpha) || defined(__alpha__)  /* Alpha OSF1 */
#   error "not implemented"

A dirty way to workaround this might be to put -DHAVE_DIRENT_H to
CFLAGS, but is that true on every arch supported by Debian? (That's
mostly a rhetorical question.)

As you can see (still in codec/dirent.h, the same series of tests),
there are a bunch of cases where dirent.h presence is assumed. So I'll
propose the possible solutions:
 1. when checking on alpha, check that __linux__ isn't defined before
    ending with "not implemented".
 2. move the alpha test after the linux one, so that we match in the
    linux test, and got the proper variable set.
 3. drop the alpha test altogether.

I think I like 1. better.

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-phototools-devel/attachments/20080526/330129ed/attachment.pgp