[Pkg-phototools-devel] hugin patch - fix debian/rules deps.

[Andreas Metzler]

On 2009-04-25 Cyril Brulebois <kibi at debian.org> wrote:
> Andreas Metzler <ametzler at downhill.at.eu.org> (25/04/2009):
[...]
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -50,8 +50,8 @@ maint-svn-snapshot:
>>  	echo "../hugin_$(UVERSION).orig.tar.gz ready"
>>  	rm -rf debian/svn
>>  
>> -configure: patch configure-stamp
>> -configure-stamp:
>> +configure: patch configure-stamp 
>               ^^^^^

> Please make that $(QUILT_STAMPFN) to avoid a possible re-./configure,
> stamp being always out of date.

Hello,
I wonder if I shouldn't simply delete this line? Iirc having a configure
target serves no purpose, all the deps are on -stamp. Its only use is
in being able to run "debian/rules configure"

>> +configure-stamp: debian/stamp-patched
                     ^^^^^^^^^^^^^^^^^^^^

Should I use $(QUILT_STAMPFN) here instead?

[...]
>> +	dh_installdirs -s

> I know it used to be -s, but why not use -a? We have no binaries that
> are built on a subset of architectures only.
[...]

No reason from my, I did not want to do unrelated changes. ;-)

Thanks for the feedback, cu andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'