[Pkg-phototools-devel] Bug#546034: Bug#546034: Bug#546034: pfstools: FTBFS with gcc 4.4 in pfspanoramic.cpp

[fabrice]

Hi,

Sebastian Harl escribió:
>> In gcc 4.4 headers (string.h), strchr is defined in 2 ways:
> 
> Hrm … talking about headers is a good point. Are you talking about
> /usr/include/string.h? That'd be provided by libc (rather than GCC). As

Yes: I'm talking about /usr/include/string.h

> you might know, Debian has recently switched to eglibc. Did Ubuntu do so

You're right: I forgot about that.

> as well? Which version of libc do you use?

it seems to be eglibc 2.10.1 (this is what libc6-dev says).

>> when __OPTIMIZE__ is set
>> char *strchr (char *__s, int __c)
>> __const char *strchr (__const char *__s, int __c)
> 
> *Both* definitions are active at the same time? Unfortunately, neither

It seems so

>> otherwise:
>> char *strchr (__const char *__s, int __c)
> 
> This one is, though.

but it's only used in a non optimized mode.

> Sorry, I was a bit unclear on that. I was talking about the environment
> in general, i.e. including the tool chain, etc.

ok :-)

> Yes, the "fix" was proposed by upstream. I'd rather call that a work-
> around for strange compiler behavior though, but I might be a bit
> "extreme" in that respect (i.e. standard-compliance) ;-)

You're totally right: it's a workaround :-)

> Anyway, I guess, I'll include the fix in the next upload as well (if
> that happens before the next upstream release). I'm a bit busy at the
> moment, though, so that won't happen within the next few days.

Thanks a lot :-)

> Thanks for the follow-up!

You're welcome ;-)
Cheers,

Fabrice