[Pkg-phototools-devel] Bug#599092: libpano13: FTBFS: Creating panorama.. please wait

[Andreas Metzler]

On 2010-10-04 Andreas Metzler <ametzler at downhill.at.eu.org> wrote:
> On 2010-10-04 Philipp Kern <pkern at debian.org> wrote:
> > On Mon, Oct 04, 2010 at 06:31:54PM +0200, Andreas Metzler wrote:
> > > Is it possible the failing buildd has too little RAM and ends up
> > > swapping itself to death?

> > Possibly but unlikely:

> > pkern at poulenc:~$ free -m
> >              total       used       free     shared    buffers     cached
> > Mem:          1957       1913         44          0        157       1325
> > -/+ buffers/cache:        431       1526
> > Swap:         4095          7       4088

> > Maybe it's hanging.  I suppose one could throw strace on it.
> [...]

> What hangs is 

> $builddirroot/libpano13-2.9.17+dfsg/tools/.libs/lt-PTmender -o output temp.txt
> in $builddirroot/libpano13-2.9.17+dfsg/tests/simpleStitch

> However strace is not helpful, nothing is printed after
> write(1, "PTmender Version 2.9.17 , originally written by Helmut Dersch, rewritten by Daniel German\n", 90) = 90

> I will need to debug this later.

Hello,
This part of tools/PTmender.c produces an endless loop, (debugging
statement added):
    char opt;
[...]
    while ((opt = getopt(argc, argv, "o:f:hsqd")) != -1) {
        
        // o       -> set output file
        // h       -> help?
        // q       -> quiet?
        
        switch(opt) { 
            
        case 'o':   // specifies output file name
            if (StringtoFullPath(&panoFileName, optarg) != 0) { 
                PrintError("Syntax error: Not a valid pathname");
                return(-1);
            }
            break;
        case 's':
            sort = 1;
            break;
        case 'd':
            ptDebug = 1;
            break;
        case 'q':
            ptQuietFlag = 1;
            break;
      
        case 'h':
            PrintError(PT_MENDER_USAGE);
            return -1;
      
        default:
            PrintError("Bug 599092, endless loop");
            break;
        }
    }


Changing opt from char to int (Thank you www.opengroup.org example
code) fixes the issue.
-------------------
--- libpano13-2.9.17+dfsg.orig/tools/PTmender.c
+++ libpano13-2.9.17+dfsg/tools/PTmender.c
@@ -257,7 +257,7 @@ int main(int argc,char *argv[])
     fullPath scriptFileName;
     fullPath panoFileName;

-    char opt;
+    int opt;

     char *currentParm;
     ptrImageFileNames = NULL;
-------------------


The other tools in libpano13-bin sufffer from the same bug. Could
somebody please confirm the fix correct?

thanks, cu andreas

-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'