[Pkg-phototools-devel] Bug#661409: rawstudio: FTBFS with undefined reference to `g_thread_init'

[Leo Iannacone]

Package: rawstudio
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu precise ubuntu-patch

Dear maintaner,
rawstudio fails to build with undefined reference to `g_thread_init'.

Excerpt from the buildlog:

rs-dir-selector.c: In function 'rs_dir_selector_class_init':
rs-dir-selector.c:60:18: warning: variable 'object_class' set but not used [-Wunused-but-set-variable]
rs-dir-selector.c:59:18: warning: variable 'widget_class' set but not used [-Wunused-but-set-variable]
gcc -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_DATA_DIR=\""/usr/share"\" -DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\" -pthread -I/usr/include/gtk-2.0 -I/usr/lib/i386-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libxml2 -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gconf/2 -I/usr/include/ -I../librawstudio/ -I../ -D_FORTIFY_SOURCE=2 -Wall -fno-strict-aliasing -DWITH_GCONF -O4 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -c rs-tag-gui.c
gcc -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_DATA_DIR=\""/usr/share"\" -DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\" -pthread -I/usr/include/gtk-2.0 -I/usr/lib/i386-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libxml2 -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gconf/2 -I/usr/include/ -I../librawstudio/ -I../ -D_FORTIFY_SOURCE=2 -Wall -fno-strict-aliasing -DWITH_GCONF -O4 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -c rs-tethered-shooting.c
rs-tethered-shooting.c: In function 'start_monitor':
rs-tethered-shooting.c:870:3: warning: 'g_thread_create' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new' instead [-Wdeprecated-declarations]
rs-tethered-shooting.c: In function 'start_interval_shooting':
rs-tethered-shooting.c:940:2: warning: 'g_thread_create' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new' instead [-Wdeprecated-declarations]
/bin/bash ../libtool --tag=CC --mode=link gcc -Wall -fno-strict-aliasing -DWITH_GCONF -O4 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Wl,-Bsymbolic-functions -Wl,-z,relro -o rawstudio application.o rs-actions.o gtk-helper.o gtk-interface.o rs-save-dialog.o gtk-progress.o rs-camera-db.o rs-cache.o rs-batch.o rs-toolbox.o rs-navigator.o rs-photo.o rs-tiff.o filename.o rs-store.o rs-preview-widget.o rs-loupe.o rs-histogram.o eog-pixbuf-cell-renderer.o rs-pixbuf.o rs-external-editor.o rs-dir-selector.o rs-tag-gui.o rs-tethered-shooting.o ../librawstudio/librawstudio-2.0.la -L/usr/lib/ -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgconf-2 -llcms -ldbus-1 -lpthread -lrt -lexiv2 -lfftw3f -llensfun -lglib-2.0 -lflickcurl -lxml2 -lcurl -lraptor -lsqlite3 -lgphoto2 -lgphoto2_port -lm -lexif -lusb -lX11 -ljpeg -ltiff
libtool: link: gcc -Wall -fno-strict-aliasing -DWITH_GCONF -O4 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o .libs/rawstudio application.o rs-actions.o gtk-helper.o gtk-interface.o rs-save-dialog.o gtk-progress.o rs-camera-db.o rs-cache.o rs-batch.o rs-toolbox.o rs-navigator.o rs-photo.o rs-tiff.o filename.o rs-store.o rs-preview-widget.o rs-loupe.o rs-histogram.o eog-pixbuf-cell-renderer.o rs-pixbuf.o rs-external-editor.o rs-dir-selector.o rs-tag-gui.o rs-tethered-shooting.o ../librawstudio/.libs/librawstudio-2.0.so -L/usr/lib/ -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 /usr/lib/i386-linux-gnu/libcairo.so -lpango-1.0 /usr/lib/i386-linux-gnu/libfreetype.so -lfontconfig -lgobject-2.0 /usr/lib/libgconf-2.so /usr/lib/i386-linux-gnu/liblcms.so -ldbus-1 -lpthread -lrt /usr/lib/libexiv2.so -lfftw3f -llensfun -lglib-2.0 -lflickcurl /usr/lib/i386-linux-gnu/libxml2.so /usr/lib/i386-linux-gnu/libcurl-gnutls.so /usr/lib/libraptor.so /usr/lib/i386-linux-gnu/libsqlite3.so -lgphoto2 -lgphoto2_port -lm -lexif -lusb -lX11 -ljpeg /usr/lib/i386-linux-gnu/libtiff.so -pthread
application.o: In function `main':
/build/buildd/rawstudio-2.0/src/application.c:708: undefined reference to `g_thread_init'
collect2: ld returned 1 exit status
make[3]: *** [rawstudio] Error 1
make[3]: Leaving directory `/build/buildd/rawstudio-2.0/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/buildd/rawstudio-2.0'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/build/buildd/rawstudio-2.0'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
******************************************************************************
Build finished at 20120210-0946
FAILED [dpkg-buildpackage died]

The full buidlog can be found at https://launchpad.net/ubuntu/+archive/test-rebuild-20120201/+build/3169265/+files/buildlog_ubuntu-precise-i386.rawstudio_2.0-1build1_FAILEDTOBUILD.txt.gz.

The patch in attachment fixes the problem. It was stolen from upstream, in the devel version.

Have a great day,

Leo.


-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric'), (100, 'oneiric-backports')
Architecture: i386 (i686)

Kernel: Linux 3.2.2-030202-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
Description: Add -lgthread-2.0 during build. Patch stolen from upstream.
Author: Leo Iannacone <l3on at ubuntu.com>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/935406
Forwarded: no

---
 configure.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- rawstudio.orig/configure.in
+++ rawstudio/configure.in
@@ -83,7 +83,7 @@ AC_CHECK_LIB(tiff, TIFFOpen, tiff_ok=yes
 fi
 AC_SUBST(LIBTIFF)
 
-pkg_modules="gtk+-2.0 >= 2.8.0 libxml-2.0 >= 2.4 gconf-2.0 >= 2.0 lcms dbus-1 exiv2 fftw3f lensfun libcurl flickcurl sqlite3 libgphoto2 x11"
+pkg_modules="gtk+-2.0 >= 2.8.0 libxml-2.0 >= 2.4 gconf-2.0 >= 2.0 lcms dbus-1 exiv2 fftw3f lensfun libcurl flickcurl sqlite3 libgphoto2 x11 gthread-2.0"
 PKG_CHECK_MODULES(PACKAGE, [$pkg_modules])
 AC_SUBST(PACKAGE_CFLAGS)
 AC_SUBST(PACKAGE_LIBS)