[Pkg-phototools-devel] Bug#682980: Bug#682980: darktable: should use system shared libraw

[Jonas Smedegaard]

On 12-07-27 at 02:28pm, David Bremner wrote:
> Jonas Smedegaard <dr at jones.dk> writes:
> 
> > Apparently (judging from latest upstream release changelog) 
> > darktable uses libraw, but does not link against the system shared 
> > library as documented at a "should" in Debian Policy §4.13.
> 
> Hi Jonas;
> 
> It's a good point, but as usual there are a few problems to be 
> overcome.
> 
> 1) the embedded copy currently leads the version in Debian by one
>    upstream release. I filed a wishlist bug 682982 asking for an upgrade
>    before I learned the following 

Ok, but do darktable really _require_ newest version of libraw?


> 2) The version in darktable is actually patched, in some way that seems
>    incompatible with upstream.  I don't know the details of this yet,
>    but I'm not too hopeful after chatting with upstream.

Indeed.  A diff between upstream LibRaw and the convenience copy shipped 
with darkroom reveals these 3 lines of difference:

+++ internal/dcraw_common.cpp<->2012-07-21 12:44:08.000000000 +0200
--- /home/jonas/src/tmp/darktable/LibRaw-0.14.7/internal/dcraw_common.cpp<----->2012-06-27 18:39:
@@ -5904,8 +5904,6 @@
       || (tiff_bps == 8 && !strstr(make,"KODAK") && !strstr(make,"Kodak") &&
 <----->  !strstr(model2,"DEBUG RAW")))
       is_raw = 0;
+  if(dng_version && max_bps > 16)
+      is_raw = 0;
   for (i=0; i < tiff_nifds; i++)
     if (i != raw && tiff_ifd[i].samples == max_samp && tiff_ifd[i].offset && tiff_ifd[i].bytes &&
 <----->tiff_ifd[i].t_width * tiff_ifd[i].t_height / SQR(tiff_ifd[i].bps+1) >


Even if upstreams could not be persuaded to carry that change, it does 
not seem unlikely to me that Debian maintainers of libraw might perhaps 
be convinced to include a patch that added above as an ifdef which 
darktable could then make use of - if it does not turn out to be 
harmless to include in all cases (I don't know the code well enough to 
judge).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-phototools-devel/attachments/20120727/b8202299/attachment.pgp>