[Pkg-phototools-devel] Bug#738522: Drop udev rules (redundant with hwdb file)

[Martin Pitt]

Package: libgphoto2-6
Version: 2.5.3.1-1
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch trusty

Hello,

The latest libgphoto is now installing a hwdb file for
identifying/tagging cameras. That does the same work as the previous
/lib/udev/rules.d/40-libgphoto2-6.rules, just much more efficiently.
Thus the udev rules file is now redundant and just a waste of time.
Can you please drop it?

Attaching the patch that I uploaded to Ubuntu for reference, but it's
quite straightforward.

Thanks for considering,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
 * debian/rules: Stop installing the udev rules; it's redundant with the
   (much more efficient) hwdb file.
diff -Nru libgphoto2-2.5.3.1/debian/rules libgphoto2-2.5.3.1/debian/rules
--- libgphoto2-2.5.3.1/debian/rules	2014-02-09 23:39:31.000000000 +0100
+++ libgphoto2-2.5.3.1/debian/rules	2014-02-10 08:30:06.000000000 +0100
@@ -39,12 +39,9 @@
 override_dh_installudev:
 	# No longer needed with current udev. But check with non-Linux architectures stuff:
 	# rm debian/libgphoto2-2/lib/udev/check-ptp-camera
-	# Generate the udev file, get it installed, and clean:
-	CAMLIBS=`ls -d debian/libgphoto2-$(major)/usr/lib/$(DEB_HOST_MULTIARCH)/libgphoto2/2*` ./packaging/generic/print-camera-list udev-rules version 175 mode 0664 group plugdev > debian/libgphoto2-$(major).udev
+	# Generate the hwdb file
 	mkdir -p debian/libgphoto2-$(major)/lib/udev/hwdb.d/
 	CAMLIBS=`ls -d debian/libgphoto2-$(major)/usr/lib/$(DEB_HOST_MULTIARCH)/libgphoto2/2*` ./packaging/generic/print-camera-list hwdb > debian/libgphoto2-$(major)/lib/udev/hwdb.d/20-libgphoto2-$(major).hwdb
-	dh_installudev
-	rm debian/libgphoto2-$(major).udev
 endif
 
 override_dh_fixperms:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-phototools-devel/attachments/20140210/33c4708e/attachment.sig>