[Pkg-phototools-devel] darktable 1.4.1 in git

[David Bremner]

Hi Jackson;

Thanks for working on darktable. I have a few comments/queries on the results.


    1. in 23ba00079fb936 you reintroduce src/external/dcraw.c into the
      master branch.  I'm pretty sure this will cause hassles later
      (since I deleted it originally to make patch management easier).
      
    2. 91e425b is not really a merge commit. That's my fault since I
      forgot to push the one commit that comprised the 1.4-2 upload.
      But it would have been nice if the commit message explained what
      happened there.

    3. upstream branch contains full upstream history, so please merge
      the release tag in before importing the tarball.

    4. have you actually tested the menu stuff? I don't normally use
      menus in my window manager, so I have not. Or at least I don't
      remember the results.  
      I get "E: darktable: menu-icon-not-in-xpm-format darktable.png"
      from lintian.

I have more or less fixed up 1-3 and updated git, but I don't know much
about menu stuff.  Can you either fix the lintian error or revert the
patch?

David

P.S. one last (wishlist) request, if you could use signed tags, that
     would be great.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 647 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-phototools-devel/attachments/20140316/b1943b4c/attachment.sig>