[Pkg-phototools-devel] Bug#738522: Drop udev rules (redundant with hwdb file) -- better patch

Martin Pitt martin.pitt at ubuntu.com
Thu May 21 09:53:02 UTC 2015


Hello again,

Martin Pitt [2014-11-04  9:48 +0100]:
> Turns out we shouldn't drop it completely, as the hwdb rules don't
> cover the generic MTP protocol (or rather, they match on the wrong
> device). But the USB rules are definitively redundant. So I propose
> this simpler debdiff which just filters them out. We have run
> essentially this in Ubuntu for two releases now.

The current upstream version fixes this in a more elegant way now,
without any need for seddery. You just need to update the udev rule
building to version "201" instead of "175", and it's all good now.

Trivial debdiff attached for the record. (This is also in Ubuntu now).

Thanks for considering,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
 - debian/rules: Generate udev rules for version "201" to avoid most rules
   which are already covered by hwdb. (Closes: #738522)
--- libgphoto2-2.5.7/debian/rules	2015-03-12 20:14:06.000000000 +0100
+++ libgphoto2-2.5.7/debian/rules	2015-05-21 11:36:43.000000000 +0200
@@ -47,7 +47,7 @@
 	# No longer needed with current udev. But check with non-Linux architectures stuff:
 	# rm debian/libgphoto2-2/lib/udev/check-ptp-camera
 	# Generate the udev file, get it installed, and clean:
-	CAMLIBS=`ls -d debian/libgphoto2-$(major)/usr/lib/$(DEB_HOST_MULTIARCH)/libgphoto2/2*` ./packaging/generic/print-camera-list udev-rules version 175 mode 0664 group plugdev > debian/libgphoto2-$(major).udev
+	CAMLIBS=`ls -d debian/libgphoto2-$(major)/usr/lib/$(DEB_HOST_MULTIARCH)/libgphoto2/2*` ./packaging/generic/print-camera-list udev-rules version 201 mode 0664 group plugdev > debian/libgphoto2-$(major).udev
 	mkdir -p debian/libgphoto2-$(major)/lib/udev/hwdb.d/
 	CAMLIBS=`ls -d debian/libgphoto2-$(major)/usr/lib/$(DEB_HOST_MULTIARCH)/libgphoto2/2*` ./packaging/generic/print-camera-list hwdb > debian/libgphoto2-$(major)/lib/udev/hwdb.d/20-libgphoto2-$(major).hwdb
 	dh_installudev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-phototools-devel/attachments/20150521/83763087/attachment-0001.sig>


More information about the Pkg-phototools-devel mailing list