[Pkg-phototools-devel] Bug#915904: Bug#915904: Bug#915904: feh: Does not store rotate images

[Andreas Tille]

Hi,

On Sat, Dec 08, 2018 at 01:06:35AM +0100, László Böszörményi wrote:
> > Version: 3.1-1
> [...]
> > since the update to version 3.1 feh does not store images that
> > are rotated via '<' / '>' keys.
>  Indeed and that's an upstream decision since the 3.0 release[1]. Quoting:
> "Flip and rotation (keys "<", ">", "|", and "_") no longer change the
> underlying file. This leaves delete ("Ctrl+Delete") as the only
> destructive action which is enabled by default.

Well, I admit I personally do not like the decision since I used the
feature for rotating all my images.  But I could live with the decision
if the alternatives would work.

> Add option --edit, which makes flip and rotation change the underlying
> file as well as the displayed image. This was the default behaviour in
> feh 1.x and 2.x".

Before I filed the bug I tried this option with no success.  Am I
missing something?

> You have three options to circumvent this. Use the 's' key to save the
> modified image with the 'feh_' filename prefix, use 'feh --edit' to
> view and be able to change your pictures (please close the bug in
> these cases if you agree with it)

I would agree and close the bug - but its not working. :-(
Can you verify this?

> or as a package uploader you can
> restore the previous behavior with patching src/options.c to set
> opt.edit unconditionally (close this bug from the changelog then).

I admit I'd consider this confusing for users if we as packager would
override upstream decisions and make a program potentially more
destructive than a user might expect after reading upstream docs.

Kind regards

       Andreas.

> [1] https://feh.finalrewind.org/archive/3.0/

-- 
http://fam-tille.de