[Pkg-phototools-devel] RFS: libexif-gtk/0.4.0-1

[Herbert Fortes]

Em 21-03-2018 08:56, Hugh McMaster escreveu:
> Hi Herbert,
> 
> Thank you for your review.  :)
> 
> On Tuesday, 20 March 2018 11:12 PM, Herbert Fortes wrote:
>> Other guy helped me about a lib that I take care. He alerted
>> me to an ABI change in another lib that is a Build-Depends on
>> the package I maintain. The upstream did not take that into
>> account an did not bump the SONAME for the new version. So I
>> probably would miss that.
>>
>> I read the ChangeLog file, but I am asking: did you
>> check if the new version has some ABI change problem?
> 
> Yes, I checked whether the SONAME needed to change. It doesn't.
> 
> Both version 0.3.5 and version 0.4.0 have a SONAME of libexif-gtk.so.5, 
> so the ABI is still 5.
> 
> Library versioning has package version 0.3.5 as 5.0.0 and package 
> version 0.4.0 as 5.1.0.
> 
>> Also:
>>
>>  - put your name in debian/copyright
> 
> Done.
> 
>> - the .symbols file is new but the version in it is old. Is
>>   not good to build with the new version?
> 
> I asked about this on #debian-mentors. As there is no change
> between 0.3.5 and 0.4.0 for the symbols file, we could technically
> use 0.3.5 as the minimum version. However, due to the upstream 
> change from 0.3.5 to 0.4.0, and the switch from shlibs to symbols,
> the consensus was to use the higher version 0.4.0.
> 
> So I've made that change too.
> 
>> I think is a good idea to upload the package to experimental first.
> Okay. There a few reverse build dependencies, so to be safe, I've
> packaged for experimental.
> 
> I've uploaded a new version to Debian Mentors:
> https://mentors.debian.net/debian/pool/main/libe/libexif-gtk/libexif-gtk_0.4.0-1.dsc
> 

Uploaded!


Thank you for the feedback.

Thank you for your work.



Regards,
Herbert