[Pkg-phototools-devel] Bug#977798: /usr/bin/feh: Memory leak when feh compiled with exif=1

[Sam Greadly]

Subject: /usr/bin/feh: Memory leak when feh compiled with exif=1
Package: feh
Version: 3.1.3-1
Severity: wishlist
File: /usr/bin/feh

Dear Maintainer,

Apologies if this ends up as a duplicate, I fear the automated one sent via
sendmail using reportbug wasn't actually sent (I haven't received a
confirmation email yet). First time doing this and still learning.

   * What led up to the situation?

Feh memory consumption increases, until all resident & swap is consumed,
then crashes (OOM).

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

Nothing out of the ordinary other than use feh, with exim=1 flag enabled.

   * What was the outcome of this action?

Memory climbed until

[1094530.907681] feh invoked oom-killer:
gfp_mask=0x400dc0(GFP_KERNEL_ACCOUNT|__GFP_ZERO), order=0, oom_score_adj=0
<snip>
[1094530.909500]
oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),task=feh,pid=929,uid=1000
[1094530.909542] Out of memory: Killed process 929 (feh) total-vm:345800kB,
anon-rss:233248kB, file-rss:60kB, shmem-rss:0kB, UID:1000 pgtables:334kB
oom_score_adj:0
[1094531.086376] oom_reaper: reaped process 929 (feh), now anon-rss:0kB,
file-rss:0kB, shmem-rss:0kB

   * What outcome did you expect instead?

Memory usage to be constant & not end up with OOM, feh crashing/stopping.


Please note, I followed up with the developer on this, refer to
https://github.com/derf/feh/issues/553

He identified and fixed the issue in the (now latest) version 3.6.1:
https://feh.finalrewind.org/

>>    Fix excessive memory consumption when showing long-running slideshows
with thousands to tens of thousands of images and feh has been compiled
with exif=1 (see https://github.com/derf/feh/issues/553)
>>    Fix memory leak when showing long-running slideshows with relatively
few images and feh has been compiled with exif=1 (ibid.)
>>    Fix memory leak when reloading an image and feh has been compiled
with exif=1
>>    Fix memory leak in --draw-exif
>>    Fix memory leak when reloading HTTP files with --no-conversion-cache


The request if possible, is to update the package in debian to 3.6.1.



-- System Information:
Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 10 (buster)
Release:        10
Codename:       buster
Architecture: armv6l

Kernel: Linux 5.4.79+
Kernel taint flags: TAINT_DIE, TAINT_CRAP
Locale: LANG=en_NZ.UTF-8, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8) (ignored:
LC_ALL set to en_NZ.UTF-8), LANGUAGE=en_NZ.UTF-8 (charmap=UTF-8) (ignored:
LC_ALL set to en_NZ.U
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages feh depends on:
ii  libc6         2.28-10+rpi1
ii  libcurl4      7.64.0-4+deb10u1
ii  libexif12     0.6.21-5.1+deb10u5
ii  libimlib2     1.5.1-1
ii  libpng16-16   1.6.36-6
ii  libx11-6      2:1.6.7-1+deb10u1
ii  libxinerama1  2:1.1.4-2
ii  yudit-common  2.9.6-8

Versions of packages feh recommends:
ii  libjpeg-progs  1:9b-1

feh suggests no packages.

-- no debconf information

Regards,
Sam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-phototools-devel/attachments/20201221/54c9c261/attachment.html>