Bug#1034121: feh: makes a bad FD_SET() call and aborts if inotify_init() fails

[Michael Gold]

Package: feh
Version: 3.9.1-2
Severity: important

Dear Maintainer,

Today I'm getting the following error whenever I try to run feh:
	feh WARNING: inotify_init failed: Too many open files
	feh WARNING: Disabling inotify-based auto-reload
	*** bit out of range 0 - FD_SETSIZE on fd_set ***: terminated
	Aborted

It turns out that inotify_init() has the very low limit of 128 instances
per user by default, and lsof shows they are mostly used by instances of
dbus-daemon, dconf-service, and xdg-desktop-portal.

feh_main_iteration() calls FD_SET(opt.inotify_fd, &fdset) if auto_reload
is enabled, regardless of whether inotify_fd is valid.  It also needs to
check 'opt.inotify_fd >= 0' in the 'if' statement.

A workaround is to use the --reload=0 command line option.

- Michael


-- System Information:
Debian Release: 12.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-7-amd64 (SMP w/32 CPU threads; PREEMPT)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages feh depends on:
ii  libc6         2.36-8
ii  libcurl4      7.88.1-8
ii  libexif12     0.6.24-1+b1
ii  libimlib2     1.10.0-4+b1
ii  libpng16-16   1.6.39-2
ii  libx11-6      2:1.8.4-2
ii  libxinerama1  2:1.1.4-3
ii  yudit-common  3.1.0-1

Versions of packages feh recommends:
ii  libjpeg-progs  1:9e-1

feh suggests no packages.

-- no debconf information

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-phototools-devel/attachments/20230409/037c9f36/attachment.sig>