RFS: imv/4.5.0-1 [Team] -- X11/Wayland image viewer intended for use with tiling window managers

[Paride Legovini]

Hello,

I can review and sponsor imv 4.5.0-1, but I prefer to work on salsa
rather than on mentors. Some comments on the changes you pushed to
debian/latest:

(1) Past upstream imports were done via `gbp import-ref`, i.e. by adding
an upstream remote and importing the upstream tag. This has the
advantage of having the full upstream commit history in the packaging
repo, and this is why d/gbp.conf had `upstream-branch =`, which you
dropped in d8e53ea1.

Now the import of 4.5.0 is done and I'm not going to ask you to revert
an re-import via import-ref, however please revert d8e53ea1 to allow the
next imports to be done from a tag via import-ref.

(2) The d/changelog style is not not very homogeneous. For example some
entries have the "d/somefile: " prefix, others do not. E.g.:

* d/u/metadata: remove obsolete fields: Contact, Name.
  Already present in machine-readable debian/copyright.
* d/salsa-ci.yml: add salsa-ci file with the salsa pipeline
* d/control: bump Standards-Version: 4.7.0, no changes needed
                                            ^^^^^^^^^^^^^^^^^ note this
[...]

By all means: use the wording you prefer! Let's just try to keep things
homogeneous.

(3) You added d/salsa-ci.yml, but it didn't trigger as that's not the
default location for CI files. I now configured the project to look for
the file in that location, so it *should* trigger with the next push.

I didn't try to build imv, I'll wait for a CI run first. We may have to
adjust something to fix some jobs, or we may want to disable some.

(4) In the future please submit your changes for review in a salsa MR,
or at least in a separate branch, so to keep the debian/latest history
cleaner. This is also valid for the changes I suggested above: ideally
they should come in a MR, especially now that we're going to have CI.
I may configure the project to restrict direct pushes to debian/latest.

Thanks for working at imv!

Paride

On 2024-06-14 05:46, xiao sheng wen(肖盛文) wrote:
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "imv":
> 
> * Package name : imv
> Version : 4.5.0-1
> Upstream contact : Harry Jeffery <harry at exec64.co.uk>
> * URL : https://sr.ht/~exec64/imv
> * License : Expat
> * Vcs : https://salsa.debian.org/debian-phototools-team/imv
> Section : graphics
> 
> The source builds the following binary packages:
> 
> imv - X11/Wayland image viewer intended for use with tiling window managers
> 
> To access further information about this package, please visit the
> following URL:
> 
> https://mentors.debian.net/package/imv/
> 
> Alternatively, you can download the package with 'dget' using this command:
> 
> dget -x https://mentors.debian.net/debian/pool/main/i/imv/imv_4.5.0-1.dsc
> 
> Changes since the last upload:
> 
> imv (4.5.0-1) unstable; urgency=medium
> .
> * Team upload.
> * New upstream version
> * Add salsa-ci file (routine-update)
> * Remove obsolete fields Contact, Name from debian/upstream/metadata
> (already
> present in machine-readable debian/copyright).
> * Bump Standards-Version: 4.7.0
> * d/copyright: update year info to 2024
> * d/control:
> - Build-Depends add libturbojpeg0-dev
> - Build-Depends add libjxl-dev, enable libjxl Backends
> * d/gbp.conf: update to use default upstream-branch
> 
> Regards,
>