[pkg-php-pear] Upgrading PHPUnit in SID

Thomas Goirand thomas at goirand.fr
Thu May 10 08:07:43 UTC 2012


Luis,

I hope you are still interested in packaging phpunit, and that you will
continue to work with me on it! :)
So far, we've done quite a large amount of work, but it's not finished.
Please keep up the good work!

Below are a few issues I have found and corrected.

1/ php-mock-object renaming
===========================
You named your package phpunit-mock-objects instead of
phpunit-mock-object (there's one more "s" at the end). So I renamed it.
Please clone again from:
git clone ssh://git.debian.org/git/pkg-php/phpunit-mock-object.git

2/ php-mock-object dependencies
===============================
The package advertizes that it depends on php5-reflection, php5-soap and
php5-spl. None of them are in Debian, but they are in core PHP. So we
can't use ${phppear:Debian-Depends}, and have to manage this by hand.

Considering the above point 1/ and 2/, it's clear to me that you didn't
even try to install php-mock-object in your system, but you've declared
it "Package ready for upload" in the wiki. Please take a bit more care
of what you do, because I'll take the blame for this if I upload.

3/ phpunit-selenium dependencies
================================
Same problem as for 2/

4/ Authorship
=============
You are missing some authors. Next time, please have a look at
ABSOLUTELY all files in the packages to make sure you don't forget
anyone. This can be very easily done with a "grep -r author *". I
suppose I don't have to remind you that this is a violation of the
license if we forget anyone.

Finally, I'm currently working on phpunit itself, and hope to upload all
our work soon. The only issue is that the FTP-Masters seem to be busy,
and the queue is growing. I really hope we can make it into Wheezy, so
please help! :)

Thomas



More information about the pkg-php-pear mailing list