[pkg-php-pear] RFS: php5-stomp - STOMP module

[Thomas Goirand]

On 05/24/2013 03:17 PM, Jonas Genannt wrote:
> Hello,
> 
> I have done packaging of php5-stomp module. It's available at git:
> 
> 	http://anonscm.debian.org/gitweb?p=pkg-php/php-stomp.git;a=summary
> 
> That package as yet one lintian warning:
> 
> 	W: php5-stomp: hardening-no-fortify-functions 	usr/lib/php5/20100525/stomp.so
> 
> But after reading  http://bugs.debian.org/673112 I think we can ignore
> it. Should we create an lintian override file for it?
> 
> Can any DD please check the package?

Hi,

I just had a quick look from the gitweb, please keep in mind that what's
below isn't a full review. It is for example missing lintian checks, etc.

First of all, the short and long descriptions aren't good enough. The
short description says absolutely nothing that isn't in the package
name, so it has no value. In the long description, only 2 words help me
to understand what the package does: "Message Brokers". The rest of
tells about the implementation, but not what the package does.

Please review both long and short description with the above in mind. By
reading them, anyone should be able to tell what the package does. It
wasn't the case for me.

Now, your package doesn't seem to be using pkg-php-tools. Please do use
it (eg: depend on it, and use it in your rules file). I will not sponsor
any new package that isn't using it because of a valid reason. It is
otherwise too hard to maintain in a consistent way. Note also that we
believe using pkg-php-tools should be a release goal for the team.

Besides this, you don't need to do a case in your postinst and postrm.

if [ "${1}" = "configure" ] || [ "${1}" = "reconfigure" ] ; then

is enough, IMO, if you don't use the other values (your script will be
shorter, so easier to read). Checking for "unknown arguments" has very
little value. Anyway, pkg-php-tools must be taking care of that, no? (I
have never packaged nor reviewed PECL extensions... others may tell more
about it)

I don't understand why you need the debian/php5-stomp.dirs file. Can't
you use install -D in your debian/rules instead? (anyway, you wont need
it if you switch to pkg-php-tools, I believe)

Please fix your package as per above,

Cheers,

Thomas