[pkg-php-pear] Ask for permission -- your PEAR packages

[Prach Pongpanich]

On Thu, May 30, 2013 at 9:25 AM, Thomas Goirand <zigo at debian.org> wrote:
>> http://anonscm.debian.org/gitweb/?p=pkg-php/phpunit.git
>
> Why did you just drop all patches? At least the patch which removes the
> LICENSE file from package.xml is needed.

 The pkg-php-tools (>=0.9) will be remove the LICENSE file.

>
> Then, why did you drop debian/patches/Removes-YUI-repport?
>

The upstream doesn't include it.

> I believe that you removed debian/patches/01_channel.patch, since there
> is a specific channel package for it, right? If so, that's fine.
>

Yes, all right.

> Another problem: phpunit declares a dependency on PHPUnit_MockObject
> (version >= 1.2.0, version <= 1.2.99), though we have only 1.1.1-2 in
> Debian. Same with php-symfony-yaml (version >= 2.0.0, version <=
> 2.99.99) and we have only 1.0.6-1 in Debian. The above dependencies
> should be solved first, before uploading a new version of php-unit.

I'll do all the above.

> Also, how did you test the new phpunit package? Did you try to rebuild
> (at least) some of the PEAR packages which depend on phpunit, for example?

I has been passed tested with php-xml-parser, php-html-template-it,
php-xml-rss and php-xml-serializer..

> Also, your package doesn't produce a phpunit.reg, but it produces a
> channel.xml file in /usr/share/.registry/.channel.pear.phpunit.de.

I build with the pkg-php-tools (1.4.1), It look like a valid phpunit.reg:

/usr/share/php/.registry
/usr/share/php/.registry/.channel.pear.phpunit.de
/usr/share/php/.registry/.channel.pear.phpunit.de/phpunit.reg

>
> All the above shows that you are not paying enough attention. Please do,
> otherwise it's hell to fix things afterward (especially the file
> conflict you've created with the .registry thing). Also, phpunit is a
> build dependency of many PEAR packages (since I did that work on the
> previous Debian release cycle), so we got to be very careful with it.
>
> Please next time, write to the list, and not to me. Things in Debian are
> better in public, as others can learn from it. Especially with phpunit,
> you should put Luis Uribe <acme at eviled.org> in the loop. He worked a lot
> last year on PHPUnit together with me. If things happened, and we have
> phpunit in Wheezy, it's thanks to him as well.

My bad, I must be very careful with it.
Thanks for your suggestion.

Regrads,
  Prach