[pkg-php-pear] Let's reconsider the way Symfony2 Components are packaged for Debian

[Mathieu Parent]

2014-08-14 20:18 GMT+02:00 Daniel Beyer <dabe at deb.ymc.ch>:
> Am Donnerstag, den 14.08.2014, 15:29 +0200 schrieb Daniel Beyer:
>> Am Donnerstag, den 14.08.2014, 15:18 +0200 schrieb Mathieu Parent:
>> > Hi Daniel, hi all,
>> >
>> > (...)
>> >
>> > Can you test against pkg-php-tools 1.14 (in experimental)?
>> >
>>
>> Already scheduled for tonight :-)
>> Really thanks a lot for your work on pkg-php-tools!
>
> Here are my findings:
>
> 1. Generated 'Depends:' to PHP changed a bit
> Pre 1.14 it was (e.g.):
>   Depends: php5 (>= 5.3.3) | php5-cli (>= 5.3.3)
> With 1.14 it now is (e.g.):
>   Depends: php5-common (>= 5.3.3)
>
> I guess this is on purpose and it looks reasonable.

Yes.

>
> 2. Alternative source directory (#750695)
> This works perfectly.

Great!

>
> 3. dev and patch releases (#754150)
> It looks like the stability suffix '-dev' and '-patch' found in a
> composer.json is dropped from the Debian version.
> With the fix I proposed for 1.12 it would have been (e.g.):
>   Depends: php-foo-bar (>= 1.2.3~dev)
> With 1.14 it now is (e.g.):
>   Depends: php-foo-bar (>= 1.2.3)
>
> I suspect this is on purpose, too. But I do not see the reason behind
> it. Can you explain it? The PHP code doing this is found here (the 'd'
> and 'p' case in getDependencies():
> http://anonscm.debian.org/cgit/pkg-php/pkg-php-tools.git/tree/share/php/pkgtools/phpcomposer/source.php?h=experimental#n176

I just wanted to make sure that -dev < -patch < -alpha < ... But this failed :-(

I will fix this to have 1.2.3~~dev < 1.2.3~~patch < 1.2.3~alpha < ...

(note the double ~)

>
> BTW.: The first point (changed generated Depends: to PHP) is the only
> difference I found in the built binary packages after I switched from
> 1.12 to 1.14 leaving d/rules untouched. Since this looks like a
> reasonable change, I found no regressions. You did a great job and again
> thanks a lot!

 Thanks

> I'll double check this tomorrow with twig, which is using
> dh_phpcomposer, as well and let you know the outcome.

OK


-- 
Mathieu