[pkg-php-pear] phpunit comments (was: Please review: phpunit 2.7.28-1 and depends)

Prach Pongpanich prachpub at gmail.com
Wed Feb 5 15:37:55 UTC 2014


On Wed, Feb 5, 2014 at 10:25 AM, Prach Pongpanich <prachpub at gmail.com> wrote:
> On Wed, Feb 5, 2014 at 5:32 AM, "David Prévot" <david at tilapin.org> wrote:
>>>>> [1] http://anonscm.debian.org/gitweb/?p=pkg-php/phpunit.git
>>
>> Please check for the remarks already provided about the other packages and
>> fix those that apply. I’ve not looked yet into the upstream part of the
>> package, but here are some stuff that could be fixed in the debian/
>> directory:
>>
>> changelog: I doubt #697343, #712667, and #736147 are all three “please
>> update to a new upstream release” bug, so please describe the relevant
>> bits of the upstream changes, and the eventually associated bug number.
>>
>> control: please use the usual name (“Debian PHP PEAR Maintainers”) for
>> Maintainers, and maybe only one Olivier Berger is enough (obergix at d.o) in
>> Uploader, maybe ask him (he may also be willing to sponsor ;).
>>
>> README.source: not sure how the doc part is relevant (documenting outdated
>> stuff), and the manpage could better be generated during the build process
>> (you can have a look at the php-doctrine-dbal and doctrine packages).
>>
>
> Thanks agian, it should be nice if I could fix all of those before you upload.
>

I have updated all of them.
It would be nice to see your comment, before I upload.

Cheers,
 Prach



More information about the pkg-php-pear mailing list