[pkg-php-pear] php-psr-log package

François-Régis frv at miradou.com
Tue Feb 11 08:41:07 UTC 2014

Hi David

Le 11/02/2014 02:18, "David Prévot" a écrit :

> [ About tests ]
> Do you wish to try and get tests running for the initial upload, or do you
> prefer to get the package uploaded for review by the ftpmasters in the
> mean time?

Result of my scuba diving into phpunit :
As php-psr-log is merely an interface (with some abstract classes), the
only way to test it would be to implement it, but then phpunit will test
the implementation more than the interface.
Am I wrong ?

> And two more details for the road:
> You may wish to run wrap-and-sort to get rid of trailing spaces and line
> in d/copyright.

Done - This is exactly the kind of magic I was searching for.

> Please get rid of (or document) the currently useless Origin entry from
> your patch header. Why is version >= 5.3.3 of php5 needed by the way?

Done for patch

phpcomposer requires 5.3.2+ and traits are implemented since 5.3.4 so
5.3.3 is a good go beetween...

Just a joke, we should definitely depend on 5.3.4+ (which is already in
wheezy) - Done



More information about the pkg-php-pear mailing list