[pkg-php-pear] Fwd: Please review php-file-find and php-file-fstab

[Mathieu Parent]

Argh, forgot to send to the list...


---------- Forwarded message ----------
From: Mathieu Parent <math.parent at gmail.com>
Date: 2014-02-14 11:56 GMT+01:00
Subject: Re: [pkg-php-pear] Please review php-file-find and php-file-fstab
To: François-Régis <frv-debian at miradou.com>


2014-02-13 16:34 GMT+01:00 François-Régis <frv-debian at miradou.com>:
> Hello everybody,
>
> I've uploaded php-file-find ( Class to facilitate the search of
> filesystems )[1] and php-file-fstab ( Class to read & write fstab ) [2].
>
> They are both recommended by php-horde-* [3]
>
> Does someone could have a look at them ?

I have reviewed them, they look really good. I will upload them,
probably this weekend.

In the meantime, you may fix the following pedantic issues/questions:
- debian/compat => 9 (and update debhelper dep in debian/control)
- you can remove 'Build-Depends-Indep: php-pear' as php-pear is a dep
of pkg-php-tools

Regards

[bd]: http://www.debian.org/doc/debian-policy/ch-relationships.html#s-sourcebinarydeps

--
Mathieu


-- 
Mathieu