[pkg-php-pear] php-analog review

[David Prévot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi François-Régis,

Le 21/02/2014 20:37, François-Régis a écrit :
> Le 21/02/2014 22:27, David Prévot a écrit :
>> Le 20/02/2014 19:22, François-Régis a écrit :
>>> Le 15/02/2014 20:17, "David Prévot" a écrit :

>>>> [tests]
>>>> DEP-8 is about testing the installed package, not the source one.

> All I've done came from php-opencloud, and I was very proud to have
> functionnal tests at build time. I need to investigate more.

I was pointing at the latest changes (patching the class load at tests
time to dismiss the embedded class, and thus use the system class).
The idea here is to use the embedded class to run the tests at build
time, and use the system class to run the DEP-8 test (and to do so,
amend the class loader).

>>>> [upstream/changelog]
>>
>>> Done as a patch (would it be better to directly mangle the web page ?),
>>
>> Updating such patch may be painful on upgrade, why not directly include
>> this file into the debian/upstream/ directory (assuming DEP-12 is going
>> to evolve as discussed in #736760 and debian-devel@), and then override
>> dh_installchangelogs in debian/rules.
> 
> After a (short) look, I feel DEP-12 is'nt quite stable, could we stay
> for this release on this really painfull patch, providing I try to make
> an idea on DEP-12 ?

The DEP-12 remark was just about using (or not) debian/upstream/ as a
directory. In many moz-ext packages, we currently use the
debian/upstream-changelog file to install the changelog (and we’ll
probably move to debian/upstream/changelog once stuff are settled).

Even if you stick to CHANGELOG.md, better use an overriden
dh_installchangelogs to install it (so it will be installed where it
belongs).

>>>> I’ll review the upstream part once you’ve double checked d/copyright.

[ Still ongoing ]

> […] should I just add
> 
> Files: examples/SplClassLoader.php
> Copyright: Jonathan H. Wage <jonwage at gmail.com>
> 
> without any License: stanza ?

The license is mandatory. If you can’t find it, ask the author: without
a DFSG-compliant license, one can only assume a non-free copyright.
Given the number of co-authors, this file is probably picked from
another project, you should be able to find which one via the commit
message or a search engine.

>>> And for the review just tell me if I can restart from scratch the alioth
>>> repo.

> Reformulation of "restart from scratch" :
> 
> $ ssh anonscm.debian.org rm -fr /git/pkg-php/php-analog.git
> $ gbp-create-remote-repo [...] # from a clean local git repo

I would prefer if you don’t do it again unless you have a good reason:
the repo seems fine now (the previous version wasn’t), so you shouldn’t
have to restart from scratch again.

> What I've done following your previous mail, I won"t make it anymore

It looks like we agree then (and yes, it was worth it to restart from
scratch two days ago, to have a proper basis. Now the basis is clean,
you shouldn’t have to rebase master (and other public branches) anymore.

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJTCOoYAAoJEAWMHPlE9r08O98H/0Tu+7zYr9vWN3pZRngYT5vm
SGy7vaWxdl7ZYix1Vk72FthH2Nqrae0D2ewUYfLNO+WfSyYkbW9EZr2sIZ3V0adV
5xRW5cR+cAzZ5FXpUEygysnPQiL08RKOqVNwYnVlB0laXRlheTu/FpTYsL0c3JBS
9FpcaYsGwEjs+i6/p0glGiEyDKNorA4BkNHPW10Y7Emgl4xaLd/e5fMd5iBZX/LK
JuvvNmDyxLmqYrrI8Rme0+57BVeV3JGv7tqw3pIFkfWrhEabqWORtouQsjwaX0xb
SAnLq/XJ0QGIkVobbmxWTaPT5O45REmvJsxOF+uF+2qHIvVuZn6uoDtf9Vr1ksw=
=gdz5
-----END PGP SIGNATURE-----