[pkg-php-pear] Let's reconsider the way Symfony2 Components are packaged for Debian

[David Prévot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

Le 25/06/2014 16:24, David Prévot a écrit :
> Le 19/06/2014 02:01, Daniel Beyer a écrit :
> 
>> It would be great if anyone could take a look onto the short and long
>> descriptions in d/control, with regards to their content as well as
>> spelling and diction. Especially the latter is quite hard for me, since
>> English is not my native language.
> 
> I’m no native English speaker either (not sure anyone on the list is)

I’ve just pushed a few minor fixes. Once you’re done, you may ask for a
complete review on debian-l10n-english at l.d.o where people will be happy
to help.

About the control file, you may wish to provide per-package Homepage: I
find it pretty handy to be pointed directly to
<http://symfony.com/doc/current/components/class_loader/introduction.htm> by
“apt-cache show php-symfony-classloader” rather than have to find it by
myself from <http://symfony.com>.

You may also fill in the Replaces, Breaks, Provides field as suggested
in /usr/share/doc/pkg-php-tools/README.Composer: even if they’re
probably useless right now, they may become useful in a later symfony
package version.

I’ve only reviewed the Component/[BC]* upstream parts so far, but
noticed that hiddeninput.exe is back in Git.

The d/copyright is also incomplete, see e.g., the output of the
following command (on one line, probably broken by my MUA):

$ git grep -i '\(copyr\|licen\)'|grep -v '"license": "MIT"'|grep -v ' *
For the full copyright and license information, please view the
LICENSE'|grep -v 'AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
DAMAGES OR OTHER'|grep -v 'The above copyright notice and this
permission notice shall be included in all'|grep -v 'to use, copy,
modify, merge, publish, distribute, sublicense, and/or sell'|grep -v
'Copyright (c) 2004-2014 Fabien Potencier'

I haven’t yet tested to build it, but the d/rules looks promising,
thanks for your work on this non-trivial packaging! You may push the
workaround for bug #754150 in a simple patch to make it a bit simpler
until it gets fixed.

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJTvsXXAAoJEAWMHPlE9r08jpAIAKf0a0f3KF0LzRiqDBfQcvbi
Yc1O/itiHDSJZym+WWYj0qRTBauNFurqv5axV+GHDB1Wc5bVvoGJlRbSuHhh+vH0
PfxNqp7wpg5w5K2y3meXkKItFSswH9/LIV3OvHvJV7DMW3gLStWzGJgO5UgI5eUX
fX5cGTrY5bdc0+ql/uIglmi/BL7QXqSQSeVv4jNs1Qwf8ujrvVRJkuAo2etcnNyj
P16k5NSVGKshWATGtoIdC/dO6dSJ1LGFdWv1nUSIdo+kkzc+PtjMXMe6gO1NHSNW
xrGxZdUAbBK6KwRxWwqV9Va80Bu5GgIAa3f1eXdca7OHi3SdgJm0xBFMxDcd5Y8=
=Vieg
-----END PGP SIGNATURE-----