[pkg-php-pear] php-analog review

[François-Régis]

Hi David,

Le 22/02/2014 19:19, David Prévot a écrit :
> Le 21/02/2014 20:37, François-Régis a écrit :
>> Le 21/02/2014 22:27, David Prévot a écrit :
>>> Le 20/02/2014 19:22, François-Régis a écrit :
>>>> Le 15/02/2014 20:17, "David Prévot" a écrit :
> 
>>>>> [tests]
>>>>> DEP-8 is about testing the installed package, not the source one.
> 
>> All I've done came from php-opencloud, and I was very proud to have
>> functionnal tests at build time. I need to investigate more.
> 
> I was pointing at the latest changes (patching the class load at tests
> time to dismiss the embedded class, and thus use the system class).
> The idea here is to use the embedded class to run the tests at build
> time, and use the system class to run the DEP-8 test (and to do so,
> amend the class loader).

Seen, in fact in php-analog, tests don't use autoload so they always
load embedded class, (require_once ('lib/Analog.php');). Do I need to
patch them (I think deleting the require_once will be enough) ? FWIU,
DEP-8 should test package "in a context as close as possible to a Debian
system", so at least using the components extract and patched by debuild
et al. Does that mean that we have to explicitely add the path of the
build-area to php_include or directly into tests (require, include and
so on) ?

In between I've saddly stolen your work to patch and un patch bootstrap.

> 
>>>>> [upstream/changelog]
>>>
>>>> Done as a patch (would it be better to directly mangle the web page ?),
>>>
>>> Updating such patch may be painful on upgrade, why not directly include
>>> this file into the debian/upstream/ directory (assuming DEP-12 is going
>>> to evolve as discussed in #736760 and debian-devel@), and then override
>>> dh_installchangelogs in debian/rules.
> 
>> After a (short) look, I feel DEP-12 is'nt quite stable, could we stay
>> for this release on this really painfull patch, providing I try to make
>> an idea on DEP-12 ?
> 
> The DEP-12 remark was just about using (or not) debian/upstream/ as a
> directory. In many moz-ext packages, we currently use the
> debian/upstream-changelog file to install the changelog (and we’ll
> probably move to debian/upstream/changelog once stuff are settled).

Understood and done.

>>>>> I’ll review the upstream part once you’ve double checked d/copyright.
> 
> [ Still ongoing ]
> 
>> […] should I just add
> 
>> Files: examples/SplClassLoader.php
>> Copyright: Jonathan H. Wage <jonwage at gmail.com>
> 
>> without any License: stanza ?
> 
> The license is mandatory. If you can’t find it, ask the author: without
> a DFSG-compliant license, one can only assume a non-free copyright.
> Given the number of co-authors, this file is probably picked from
> another project, you should be able to find which one via the commit
> message or a search engine.

As SplClassLoad.php is only used in psr-0.log and the upstream author
doesn't seem to respond to license claims [1] I propose to skip it and
to patch psr-0.php. In fact psr-0.php is now irrelevant and could be
skipped to... It's not satisfying at all but I do'nt see better solution.

Thak's for your help.

Regards,

-- 
François-Régis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 880 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140305/21f3094d/attachment.sig>