[pkg-php-pear] Fwd: Please review php-file-find and php-file-fstab

[Mathieu Parent]

2014-03-04 17:28 GMT+01:00 François-Régis <frv-debian at miradou.com>:
> Hi Mathieu,

Hi François-Régis,

Sorry for the delay...

> Le 22/02/2014 10:02, Mathieu Parent a écrit :
>> 2014-02-22 3:14 GMT+01:00 François-Régis <frv-debian at miradou.com>:
>>> Le 15/02/2014 14:58, Mathieu Parent a écrit :
>>>> About php-file-find:
>>>> - I couldn't build it with gbp when the first build failed. It seems
>>>> that your .gitignore file is the guilty (your debian branch=master
>>>> shouldn't change anything outside of the debian dir)
>>>> - your dep8 tests depend on php-file-find: IMO it should depend on "@"
>>>> instead [dep8]
>
> Done,

Good.

>>> You're right it is not uploadable... I thought I'd solved some problems
>>> (it's build with gbp at home) in fact not. My main problem comes from
>>> the buggy tarball provided by upstream [1].
>>>
>>> I think I need to restart from scratch using only github repo [2].
>>
>> OK. Tell me, once it's done.
>
> I think it's done now, would you have a look ?

I'm not sure if it is good to go from upstream git. The tarball looks
so different (everything is mioved to the File_Find_* subdir) that
cherry-picking is not possible.

I would advice to use tarball instead (this means another git repo
init). I'm open to any other workflow, but don't see a practical one
using upstream git.

Regards

-- 
Mathieu