[pkg-php-pear] Fwd: Please review php-file-find and php-file-fstab

[François-Régis]

Hi Mathieu,

Le 11/03/2014 18:56, Mathieu Parent a écrit :
> 2014-03-10 16:54 GMT+01:00 François-Régis <frv-debian at miradou.com>:
>> Le 08/03/2014 09:30, Mathieu Parent a écrit :
>>> 2014-03-04 17:28 GMT+01:00 François-Régis <frv-debian at miradou.com>:
>>>> Le 22/02/2014 10:02, Mathieu Parent a écrit :
>>>>> 2014-02-22 3:14 GMT+01:00 François-Régis <frv-debian at miradou.com>:
>>>>>> Le 15/02/2014 14:58, Mathieu Parent a écrit :
>>>>>> You're right it is not uploadable... I thought I'd solved some problems
>>>>>> (it's build with gbp at home) in fact not. My main problem comes from
>>>>>> the buggy tarball provided by upstream [1].
>>>>>>
>>>>>> I think I need to restart from scratch using only github repo [2].
>>>>>
>>>>> OK. Tell me, once it's done.
>>>>
>>>> I think it's done now, would you have a look ?
>>>
>>> I'm not sure if it is good to go from upstream git. The tarball looks
>>> so different (everything is mioved to the File_Find_* subdir) that
>>> cherry-picking is not possible.
>>>
>>> I would advice to use tarball instead (this means another git repo
>>> init). I'm open to any other workflow, but don't see a practical one
>>> using upstream git.
>>
>> Upstream has corrected the bug I've filled [1]. It's a good news as
>> package is tagged "not maintained" by pear and we now have a functionnal
>> tarball.
>>
>> I've updated the pkg-php repo starting from this tarball (it'much cleaner).
>>
>> I've also made some changes : drop the dep-8 patch and change
>> debian/rules accordingly to run tests from the correct tests directory.
>>
>> Hope it's in good shape now.
> 
> Yes. I've uploaded it now. It will be in the NEW queue soon.

Thank you.

> Still one problem (no hurry here): all tests are skipped:
> 
> phpunit --colors File_Find-*/tests
> PHPUnit 3.7.28 by Sebastian Bergmann.
> 
> SSSSSSS
> 
> Time: 318 ms, Memory: 1.75Mb
> 
> OK, but incomplete or skipped tests!
> Tests: 7, Assertions: 7, Skipped: 7.

I must investigate as debuild don't skip test but pbuilder does...
Working on it.


-- 
François-Régis