[pkg-php-pear] php-analog review

["David Prévot"]

Hi François-Régis,

> Le 23/03/2014 21:44, David Prévot a écrit :
>>>> Le 05/03/2014 18:22, François-Régis a écrit :

> There are no more doubt
> on license. So SplClassLoad.php may be included in package.

You must document the license in debian/copyright then.

>> About DEP-8 tests, you must at least install the package to be tested (@
>> should be a better friend than php-file-find here).
>
> I have read any doc available on DEP-8 and made some tries to have adt
> tests on my local packages. I can't confirm success... So what you're
> saying  is for me an enigma on which I'll try to work to morrow.

debian/tests/control currently read as:

 Tests: phpunit
 Depends: php-file-find, phpunit

while php-file-find is a non-existing (yet) package, so the failing (well,
skipped) test is not a surprise. You should use “@” instead, see
<http://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=blob_plain;f=doc/README.package-tests;hb=HEAD>.

Furthermore, debian/patches/dont_use_splclassloader.patch contains a
spurious change at the end of file, please drop it.

Regards

David