[pkg-php-pear] php-mail{-mime, } review (was: Build failure with phpunit 4)

[David Prévot]

Hi Prach,

Le 03/10/2014 02:18, Prach Pongpanich a écrit :
> On Fri, Oct 3, 2014 at 12:50 PM, Prach Pongpanich <prachpub at gmail.com> wrote:
>> RFS,I have updated php-mail-mime with following changes:

Thanks!

>>   * Add DEP-8 compliant tests

It seems like they don’t test the installed version of the package
(rather the source), and they may never fail (the last command will
never fail).

> And php-mail with following changes:

>   * Bump Standards-Version to 3.9.6

Ditto. You may also use with-recommends to avoid skipping a test.

I made the following trick to use the installed version for testing
php-console-table. Maybe something less hackish could be done, but for
the moment, it seems to do the trick:

http://anonscm.debian.org/cgit/pkg-php/php-console-table.git/tree/debian/tests/pear

> #! /bin/sh
> mv Console_Table-*/Table.php .
> pear run-tests Console_Table-*/tests
> exit=$?
> mv Table.php Console_Table-*
> exit $exit

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20141003/428e55f8/attachment.sig>