[pkg-php-pear] php-mail{-mime, } review

Prach Pongpanich prachpub at gmail.com
Sat Oct 4 19:05:19 UTC 2014


Hi David,

On Sat, Oct 4, 2014 at 11:57 PM, David Prévot <david at tilapin.org> wrote:
> Hi,
>
> Le 03/10/2014 16:03, David Prévot a écrit :
>> Le 03/10/2014 02:18, Prach Pongpanich a écrit :
>>> On Fri, Oct 3, 2014 at 12:50 PM, Prach Pongpanich <prachpub at gmail.com> wrote:
>>>> RFS,I have updated php-mail-mime with following changes:
>
>>>>   * Add DEP-8 compliant tests
>>
>> It seems like they don’t test the installed version of the package
>> (rather the source), and they may never fail (the last command will
>> never fail).
>>
>>> And php-mail with following changes:
>>
>>>   * Bump Standards-Version to 3.9.6
>>
>> Ditto. You may also use with-recommends to avoid skipping a test.
>
> According to <https://wiki.debian.org/Teams/DebianPHPGroup/PHPUnit-4.2>,
> I believe those two packages are the only remaining blockers for a
> phpunit 4 upload to Sid.
>

I have updated those packages.

> Prach, if you agree, feel free to upload phpunit 4 ASAP to Sid. php-mail
> and php-mail-mime should also be uploaded with a fix (with or without
> DEP-8 compliant tests: no need to let the best be the enemy of the
> better), but we can handle that in a timely manner, even (a few days)
> after phpunit 4 makes it to Sid.
>

Thanks to everyone for the help!,  I recently uploaded phpunit-4 to unstable.

Regards
Prach



More information about the pkg-php-pear mailing list