[pkg-php-pear] Let's reconsider the way Symfony2 Components are packaged for Debian

[Daniel Beyer]

On Sun, 2014-09-07 at 16:27 -0400, David Prévot wrote:
> [ Again, please stop CCing me on reply to the list. ]
> 

Sorry about that. I now have put a large "Don't CC!" post-it on my
monitor.


> Le 07/09/2014 15:28, Daniel Beyer a écrit :
> > On Sat, 2014-09-06 at 14:26 -0400, David Prévot wrote:
> >> Le 06/09/2014 14:04, Daniel Beyer a écrit :
> >>> On Sat, 2014-09-06 at 13:01 -0400, David Prévot wrote:
> >>>> Le 05/08/2014 17:24, Daniel Beyer a écrit :
> >>>>> On Sun, 2014-08-03 at 17:11 +0200, Daniel Beyer wrote:
> 
> > I think I'm done with d/copyright. Everything is pushed into the git
> > repo.
> 
> Details:
> - looks like your BSD-* should be BSD-3-clause-* (and BSD-php-parser
>   should probably be a simple BSD-3-clause since it’s generalist);

Done

> - you may wish to regroup paragraphs about the same license.

Done, by respecting depths and wildcards. You can check that with:
# grep -E "^(License|Files):" debian/copyright

> - wrap-and-sort gives a more usual d/control (and drop the useless
>   d/copyright last line).

Done - and thanks for mentioning an other helpful tool in Debian.

> 
> > A few (non-blocking) things are still open:
> […]
> > - No tests are run, mainly due to two missing build-dependencies [1]. I
> > vote taking care about enabling tests during build after the package
> > made it into Debian.
> 
> Please, just deactivate the tests you can’t run instead.

The other reason is, that currently there is no support in d/rules to
run any test at all. I'll check how this can be done, since in fact most
of the tests should already run. I think I can work on this Wednesday.

> 
> I’ll upload php-doctrine-data-fixtures ASAP (it’s already almost ready),
> and may have a look at php-email-validator if nobody beats me to it once
> I’m done reviewing d/copyright.

Thanks.

> 
> > Le 05/08/2014 17:51, David Prévot a écrit :
> >> Le 05/08/2014 17:24, Daniel Beyer a écrit :
> > 
> >>>>> B) Simply (at least for now) drop the two bridges and
> >>>>>    remove the non-existing 'Suggests:'.
> >>>> 
> >>>> No need to remove non-existing 'Suggests:' since they can (or not) be
> >>>> packaged later by interested parties.
> 
> Why do you override the missing suggests into “none”? E.g.,
> php-ircmaxell-password-compat may be useful if the package gets backported.

I thought it is a violation of the Debian policies to Suggests: non
existing packages. But you are right. It's not a violation at all and
thus I removed those overrides.

> 
> Now I’ll dive into d/copyright review, and will be back with more (or
> none) remarks once done (or before, if stuff can be addressed in the
> mean time).

Great. I just pushed the changes noted above. You might want to pull
them before proceeding.

One more thing came up my mind while I grouped the licenses:
I'm not sure if it's right what I've done with
src/Symfony/Component/CssSelector/* in d/copyright. If it really is a
port of the Python cssselector library (as pointed out by Symfony's
upstream), than it should be "Expat and BSD-3-clause-cssselector" - even
Symfony's upstream does not include this license anywhere in its
code/documentation (as it would be required by the BSD 3-clause). What
do you think?


Daniel.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140908/b4c38a37/attachment-0001.sig>