[pkg-php-pear] phpunit-comparator review (was: Updating php-code-coverage)

[Prach Pongpanich]

Hi David,

On Thu, Sep 11, 2014 at 9:37 PM, "David Prévot" <david at tilapin.org> wrote:
> Hi Prach,
>
>> I've pushed the phpunit-comparator to repository [0], could you please
>> take a look?
>
> Great, I should be able to take the phpab bit I didn’t manage to use
> yesterday for php-code-coverage. Besides phpab not yet being uploaded and
> the missing tests, I believe the package is ready for upload (I just
> pushed a minor tweak for clean).
>
> Is phpab ready for review and upload too?
>

Yes.

> About the tests, I’ve managed to run them with a simple symlink
> (SebastianBergmann/Comparator -> ../src) and a homemade
> vendor/autoload.php:
>
> ---------------->%----------------
> <?php
> require_once 'Symfony/Component/ClassLoader/ClassLoader.php';
> use Symfony\Component\ClassLoader\ClassLoader;
> $loader = new ClassLoader();
> $loader->setUseIncludePath(true);
> $loader->register();
> $loader->addPrefixes(array(
>         'SebastianBergmann\\Comparator' => __DIR__.'/..',
> ));
> ----------------%<----------------
>
> You may consider patching something like that with the needed additional
> build-dependencies to run the tests at build time, and then add the
> relevant DEP-8 bits.
>

I didn't to run the tests because in a composer.json that requires
phpunit": "~4.1".
Thank you for testing with a PHPUnit 3.7.x, I just updated it to run the tests.

Regards,
Prach