[pkg-php-pear] Symfony package review (was: Let's reconsider the way Symfony2 Components are packaged for Debian)

[David Prévot]

Hi Daniel,

Le 23/09/2014 08:59, Daniel Beyer a écrit :
> Am Montag, den 22.09.2014, 14:49 -0400 schrieb David Prévot:
>> Le 21/09/2014 18:09, David Prévot a écrit :
>>> Le 21/09/2014 14:14, Daniel Beyer a écrit :

>> Now I’m done, and I don’t have much to add. Let me focus on the
>> important points (advices and other non blocking suggestions from the
>> previous message stripped away).

> Okay, thanks. I therefore delay any potential work on those from the
> previous message (most likely I schedule them even behind a first upload
> of the package).

That’s fine (I continue to skip parts that are OK as is for Jessie,
e.g., the well working d/rules, or the absence of a common metapackage).

>>>> On Mon, 2014-09-08 at 10:04 -0400, David Prévot wrote:
>>>>> Le 08/09/2014 02:35, Daniel Beyer a écrit :
>>>>>> On Sun, 2014-09-07 at 16:27 -0400, David Prévot wrote:
>>>>>>> Le 07/09/2014 15:28, Daniel Beyer a écrit :

>>> Another thing on the top of my head: in
>>> 5b6fa15f (Update versioned Replaces: and Breaks: fields in d/control)
>>> the version (“Breaks: php-symfony-classloader (<<2.3.19~)”) won’t work

>> That makes me think I may use (except for the php-symfony-console
>> standalone package that should be versionned 2.3.19+dfsg-1~sid1 anyway),
>> a simple 2.3.19-1 version for all the standalone package I’m preparing

> <{You already added: 'using "<< 2.3.19+dfsg" will be fine.'}
> 
> I like the 2.3.19-1 versions more. But the versions in Replace: and
> Breaks: needs to be increased to something like '2.3.19+dfsg~' or (as I
> understood) they will not work. I'm not sure what will happen with no
> '<<VERSION' at all, but I'll try that out...

It should work:

	2.3.19-1 << 2.3.19+dfsg~ << 2.3.19+dfsg << 2.3.19+dfsg-1

- the standalone php-symfony-classloader will soon be upgraded to
  2.3.19-1;
- the binary php-symfony-class-loader from symfony, version
  2.3.19+dfsg-1, will replace it;
- anything between 2.3.19-1 and 2.3.19+dfsg-1 may be used to replace,
  or break, or whatever;
- one of the shorter in between form, still being explicit, is
  2.3.19+dfsg: it will allow to upload, e.g., a 2.3.19-2 update of the
  standalone package in the mean time, and will work as is even if the
  big symfony package gets uploaded to backports (with a
  2.3.19+dfsg-1~deb70-1 version for example).

One of the shortest form I can think of is 2.3.19+, that should be fine,
but I just think it’s less explicit (but that’s just some nipticking
bikeshed, chose whatever you like that will actually do the job).

>> As for the php-symfony-yaml, maybe a versionless transition could be
>> considered too (and easier). We should run test upgrade to be sure
>> anyway (I encourage you to do some test upgrade on your own, I’ll do
>> some too on my own before uploading). (I have some doubts about the
>> compatibility of a versionless transition with a transitional dummy
>> package anyway…)

> A few days ago, when I added DEP-8 tests, I ran into a pretty bad
> situation: apt complained about (the new) php-symfony-yaml and
> php-symfony2-yaml sharing same files

I see. I’m running into a similar issue while testing the standalone
php-symfony-yaml package (and even prepared a longish reply to the
“php-symfony2-yaml to php-symfony-yaml” that was not worth sending IMHO:
I should better do it than talk about it… Anyway, attached (without
review), make your own mind if you have some time to loose reading it
;). I do intend to upload a fixed version of phpunit (and the few other
affected bits) in coordination with the php-symfony-yaml upload soon,
maybe today…

> I think now it's time to dig into this and do, as you suggested, some
> test upgrades. I'll let you know as soon as I have findings.

Don’t waste too much time on php-symfony-yaml (that should be handled
very soon anyway), please mainly focus on the class(-)loader and
event(-)dispatcher rename. Is this last bit the actual last thing to do
before considering a final review before the upload (fair question: I
may still be short on coffee to see clearly, and haven’t yet looked at
your last changes in Git ;)?

Regards

David
-------------- next part --------------
An embedded message was scrubbed...
From: =?UTF-8?B?RGF2aWQgUHLDqXZvdA==?= <david at tilapin.org>
Subject: Re: [pkg-php-pear] php-symfony2-yaml to php-symfony-yaml transition
Date: Mon, 22 Sep 2014 18:24:59 -0400
Size: 4718
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140923/e2a60923/attachment-0001.mht>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140923/e2a60923/attachment-0001.sig>