[pkg-php-pear] symfony: New version (2.7.4+dfsg-1) ready for review

[Daniel Beyer]

Hi David,

As I wrote yesterday, I've done some work on this and upgraded to 2.7.5
as well as done some general improvements, based on your suggestions.
Thus I'm replying to your earlier mail...

On Mon, 2015-09-14 at 11:57 -0400, "David Prévot" wrote:
> Hi Daniel,
> 
>  (...)
> 
> > 2. Include tests in autoload.php files
> > (...)
> 
> I was afraid this might get in the way of packages that depends on Symfony
> stuff for their own tests, but indeed, it looks harmless according to some
> tests. The main downside might be too much useless lines in those static
> autoloader, but we can certainly live with that in the mean time. Maybe we
> could build two autoloader per package, one for the internal test suite,
> and one for the deb (I might have a look at that if I find enough time).
> 

I agree. I thought about working on this today, but then skipped it out
and focus on getting a new Symfony version ready instead. But I keep
this in mind for a future release.


> On the bright side, the tests seem to be running even if the latest
> version of php-symfony-* packages are not installed on the system.
> 

Yes, and this was the main reason why I introduced a new way to deal
with vendor/autoload.php. The previous way we've done this had the issue
to loaded quite some files from system paths and not the (correct ones)
from the src.


> I should have time for a closer look at it next weekend, maybe even during
> the week (less sure). I pushed a few details on review/2.7.4 in the mean
> time, feel free to tell me if some of them are not relevant.
> 

Please forget about review/2.7.4. I just pushed a review/2.7.5 branch.
It contains your all changes, except "f9b7643 Prefer removal on clean
target". This time I did not forget about d/clean and have done that
this way in 4749789, making f9b7643 obsolete.
Please note that I updated your commit message for "Drop now useless
header" (6deb454 -> 1defe47), since I dropped (details below)
d/p/DEP-8/Use-installed-class-for-DEP-8-tests.patch.


> Another detail: aff6b052ad could have been less noisy if the new patch
> were added after the existing ones (avoiding a renaming of all the other
> ones), or even if the vendor/autoload.php was added in the debian
> directory (might be easier to edit a file than a patch). Looks like the
> php-swiftmailer b-d was silently added with this change too (not sure if
> it was on purpose).
> 

You're totally right. To prevent such noisy diffs in future I added
"a37c60d Remove prefixed 'NNNN-'-numbering for Debian patches".
I liked your idea to maintain the autoloads directly in d/, thus this
time it is no longer done using patches, but with two simple files:
d/autoload.build.php and d/autoload.DEP-8.php.
The new b-d php-swiftmailer is actually really needed. I made an
explicit commit for it.


It would be great if you find the time to review the review/2.7.5
branch, update the changelog, merge into master, etc. and do an upload
to the Debian archives, if you think it is ready. If you find something,
please let me know. I might be able to do some more work on it during
the week.

Greetings
Daniel