[pkg-php-pear] Symfony 2.8.4

[Daniel Beyer]

Hi David,

On Thu, 2016-03-31 at 21:04 -0400, "David Prévot" wrote:
> Hi Daniel,
> 
> > I suggest we do the following:
> > - Skip Symfony 2.8.4 for Debian at all (or at least for now)
> > - Take the easy approach and accept that the test failing in 2.8.4 are
> >   skipped in future (starting most likely with 2.8.5)
> 
> Why not just exclude the dns-sensitive group for now? I've pushed that
> change and a few more (to pass more tests) in wip/taffit/2.8.4 ready to
> upload if that's OK with you.
> 

Hm, I think I missed the forest for the trees - yes, let's do so.

Sadly DEP-8 tests are failing on my local build setup. It is the same
issue you dealt with in commit:
3a7fc76 Don’t load php-parser via its reverse (build-)dependencies for
Bridge/Doctrine tests

The real cause of the failures is in php-doctrine-common 2.4.3-2, which
uses syntax [1] no longer working for PHP 7. I attached a demo.php, that
demonstrate the problem (works with PHP 5, fails with PHP 7).

With 2.6.1-1 from branch master of php-doctrine-common's Debian
packaging repository, it works (even without 3a7fc76) just fine for
build and DEP-8 tests.
Since I suspect there is a reason to keep the 2.4 series in Debian, I
prepared a patched on in branch 2.4-fix-ClassLoader-for-php7 [2].

I updated branch wip/dabe/2.8.4 (symfony pkg repo) to contain everything
from wip/taffit/2.8.4 (looks good to me), except commit 3a7fc76. In my
opinion it's ready to be uploaded, given php-doctrine-common in either
2.6.1-1 or 2.4.3-3 is uploaded, as well.


Greetings
Daniel

[1] https://github.com/doctrine/common/blob/v2.4.3/lib/Doctrine/Common/ClassLoader.php#L248
[2] https://anonscm.debian.org/cgit/pkg-php/php-doctrine-common.git/log/?h=2.4-fix-ClassLoader-for-php7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demo.php
Type: application/x-php
Size: 301 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20160401/0d0963ac/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20160401/0d0963ac/attachment-0001.sig>