[pkg-php-pear] adding nocheck and stage1 (bootstrapping build profiles)

[Nish Aravamudan]

Hi,

As part of Ubuntu 16.04's initial transition (before PHP5 and PHP7 were
coinstallable), we had to put in deltas in a number of packages so that
we could bootstrap some basic tooling, in particular phpunit, symfony
and doctrine. I have debdiffs that I can send Debian for these packages
that add the appropriate control and rules changes -- but I'm curious if
coinstallability will be a priority in future versions of PHP as well,
in which case I'm not sure the bootstrap profiles are really necessary.
They don't add overhead, per se -- but I don't want to send a bunch of
patches that are basically noise. Thoughts?

Thanks,
Nish

E.g.:

diff --git a/debian/control b/debian/control
index 6fa8c97..b97cd36 100644
--- a/debian/control
+++ b/debian/control
@@ -11,9 +11,9 @@ Build-Depends: ant,
                php-soap,
                php-text-template,
                phpab,
-               phpunit,
+               phpunit <!nocheck !stage1>,
                phpunit-exporter,
-               pkg-php-tools (>= 1.29~)
+               pkg-php-tools (>= 1.32~)
 Standards-Version: 3.9.8
 Homepage: https://github.com/sebastianbergmann/phpunit-mock-objects
 Vcs-Git: git://anonscm.debian.org/pkg-php/phpunit-mock-object.git
diff --git a/debian/rules b/debian/rules
index 21dd76f..37ca6b4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -11,7 +11,7 @@ override_dh_auto_build:
 		src/Framework/MockObject
 
 override_dh_auto_test:
-ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))
+ifeq (,$(filter nocheck stage1, $(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))
 	# Build autoload.php for tests
 	mkdir --parents vendor
 	phpab \

-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd